2073865 - [riscv64] Enable single-step profiling on riscv64-simulator

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[Rong Bao [:csmantle]]

The simulator itself already supports related facilities. This can be enabled with a few correctness and hygiene fixes.

Comment 1

[Rong Bao [:csmantle]]

Attachment: Bug 2073865 - [riscv64] Part 1: Fix WASM epilogue structure on riscv64. r=#spidermonkey-reviewers!,rhunt!

The original epilogue structure is rather inexplicable, including
misplaced *ret=, strange nop, unreasonably-large pool forbidden zone,
etc. Clean them up here.

Related test harness is updated to match the new epilogue shape.

Comment 2

[Rong Bao [:csmantle]]

Attachment: Bug 2073865 - [riscv64] Part 2: Fix transient intermediate $ra value in CollapseWasmFrameSlow. r=#spidermonkey-reviewers!,rhunt!

Comment 3

[Rong Bao [:csmantle]]

Attachment: Bug 2073865 - [riscv64] Part 3: Implement link register-based trampoline for riscv64 in MakeReturnCallTrampoline. r=#spidermonkey-reviewers!,rhunt!

Comment 4

[Rong Bao [:csmantle]]

Attachment: Bug 2073865 - [riscv64] Part 4: Enable single-step profiling on riscv64-simulator. r=#spidermonkey-reviewers!

A related test is updated to account for the enablement.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8a2cac5a35b6
https://hg.mozilla.org/integration/autoland/rev/2d644f9f2721
[riscv64] Part 1: Fix WASM epilogue structure on riscv64. r=rhunt,spidermonkey-reviewers
https://github.com/mozilla-firefox/firefox/commit/64bfe31f9932
https://hg.mozilla.org/integration/autoland/rev/f70497eb5224
[riscv64] Part 2: Fix transient intermediate $ra value in CollapseWasmFrameSlow. r=rhunt,spidermonkey-reviewers
https://github.com/mozilla-firefox/firefox/commit/374282de1fd2
https://hg.mozilla.org/integration/autoland/rev/d034c65c0e02
[riscv64] Part 3: Implement link register-based trampoline for riscv64 in MakeReturnCallTrampoline. r=rhunt,spidermonkey-reviewers
https://github.com/mozilla-firefox/firefox/commit/6842d443819b
https://hg.mozilla.org/integration/autoland/rev/ce2c26efa573
[riscv64] Part 4: Enable single-step profiling on riscv64-simulator. r=spidermonkey-reviewers,jandem

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2d644f9f2721
https://hg.mozilla.org/mozilla-central/rev/f70497eb5224
https://hg.mozilla.org/mozilla-central/rev/d034c65c0e02
https://hg.mozilla.org/mozilla-central/rev/ce2c26efa573