Closed Bug 2074573 Opened 1 month ago Closed

[wpt-sync] Sync PR 62866 - Create an initial CSSValue which can be applied to view-timeline-inset

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
159 Branch
Tracking Status
firefox159 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 62866 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/62866
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

Create an initial CSSValue which can be applied to view-timeline-inset

view-timeline-inset is expected to be CSSValueList of CSSValuePair
values. ViewTimelineInset::InitialValue() incorrectly returned a
CSSIdentifierValue for 'auto' instead of an 'auto' pair.

This caused a crash when re-applying the initial value for inheritance
when effective zoom changes which round-trips a computed CSSValue
through ApplyParentValue().

Create an 'auto' pair instead of a single identifier.

Bug: 562857743
Change-Id: I3813e4d3f206905c140b0d01d8405e8871d05a58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8425566
Commit-Queue: Rune Lillesveen \<futhark@chromium.org>
Reviewed-by: David A \<awogbemila@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1702562}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 141 tests and 2 subtests

Status Summary

Firefox

OK : 24
PASS : 1[GitHub] 9[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 435[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 509[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 512[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL : 85[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 116[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 119[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]

Chrome

CRASH: 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e3cc212319c0 https://hg.mozilla.org/integration/autoland/rev/362be236cc02 [wpt PR 62866] - Create an initial CSSValue which can be applied to view-timeline-inset, a=testonly
Status: NEW → RESOLVED
Closed: 1 month ago
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 159 Branch
You need to log in before you can comment on or make changes to this bug.