[wpt-sync] Sync PR 62869 - [masonry] Account for rule visibility in grid lanes
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox159 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 62869 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/62869
Details from upstream follow.
Javier Contreras <javiercon@microsoft.com> wrote:
[masonry] Account for rule visibility in grid lanes
Grid-lanes gap geometry did not record empty adjacent lanes, causing
around and between to paint rules that should be hidden.The current proposal is to consider a gap segment as empty after if
there are no items in the next lane, empty before if there are no items
in the previous lane, and empty both if there are no items in either
lane. [1]We use the already built logic that determines blocked states for
segments, using vectors of occupants in the track before the main gap
being processed and after the main gap being processed[1] https://github.com/w3c/csswg-drafts/issues/14489.
Bug: 343257585
Change-Id: I6d5e9aecf145972c66593f90bfa3ade4a7204eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8428244
Reviewed-by: Alison Maher \<almaher@microsoft.com>
Commit-Queue: Javier Contreras \<javiercon@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1702588}
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 1•1 month ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=96005
| Assignee | ||
Comment 2•1 month ago
|
||
CI Results
Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 112 tests
Status Summary
Firefox
PASS: 4[GitHub] 6[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 11[GitHub] 106[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
Chrome
PASS: 4
FAIL: 11
Safari
PASS: 5
FAIL: 10
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-gaps/grid-lanes/column-gap-decorations-001.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-002.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-003.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-004.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-005.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-006.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-007.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-008.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-009.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-010.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-011.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-012.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-013.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-014.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-015.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-016.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-017.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-018.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-019.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-020.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-021.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-022.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-023.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-024.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-025.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-026.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-027.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-028.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-029.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-030.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-031.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-033.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-036.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-037.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-038.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-039.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-040.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-041.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-break-normal.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-break-stacking-axis-noop.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-inset-across-spanner.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-inset-cap-vs-junction.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-inset-negative-cap.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-inset-negative-junction.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-inset-non-overlapping-gutter-percentage.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-inset-overlap-join.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-inset-overlapping-gutters-percentage.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-inset-percentage.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-inset-with-break-none.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-list-dense-order.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-list-fill-reverse.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-list-fill-track-reverse.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-list-grid-axis.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-list-repeat-auto-stacking.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-list-repeat-integer-stacking.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-list-spanner-independent.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-list-stacking-types.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-list-track-reverse.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-overlap-column-over-row.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/column-gap-decorations-rule-visibility-items-around-003.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-gaps/grid-lanes/column-gap-decorations-rule-visibility-items-empty-all.html [wpt.fyi]:
FAIL(Chrome:PASS, Safari:FAIL) - /css/css-gaps/grid-lanes/column-gap-decorations-rule-visibility-items-repaint-all-to-around.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-gaps/grid-lanes/column-gap-decorations-rule-visibility-items-repaint-normal-to-between.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-gaps/grid-lanes/row-gap-decorations-001.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-002.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-003.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-004.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-005.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-006.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-007.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-008.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-009.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-010.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-011.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-012.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-013.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-014.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-015.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-016.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-017.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-018.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-019.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-020.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-021.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-022.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-023.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-024.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-break-normal.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-inset-cap-vs-junction.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-inset-overlap-join.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-inset-overlap-negative.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-inset-overlapping-gutters-percentage.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-inset-percentage.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-list-fill-reverse.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-list-fill-track-reverse.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-list-repeat-integer-stacking.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-list-stacking-axis.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-list-track-reverse.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-overlap-column-over-row.html [wpt.fyi]:
FAIL - /css/css-gaps/grid-lanes/row-gap-decorations-rule-visibility-items-all-002.html [wpt.fyi]:
FAIL(Chrome:PASS, Safari:FAIL) - /css/css-gaps/grid-lanes/row-gap-decorations-rule-visibility-items-around-003.html [wpt.fyi]:
FAIL(Chrome:PASS, Safari:FAIL) - /css/css-gaps/grid-lanes/row-gap-decorations-rule-visibility-items-between-003.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:PASS) - /css/css-gaps/grid-lanes/row-gap-decorations-rule-visibility-items-between-004.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-gaps/grid-lanes/row-gap-decorations-rule-visibility-items-empty-all.html [wpt.fyi]:
FAIL(Chrome:PASS, Safari:FAIL) - /css/css-gaps/grid-lanes/row-gap-decorations-rule-visibility-items-repaint-all-to-around.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-gaps/grid-lanes/row-gap-decorations-rule-visibility-items-repaint-normal-to-between.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL)
Comment 4•1 month ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/00f6e0f1f04f
https://hg.mozilla.org/mozilla-central/rev/1a9ad3baac8a
Comment 5•1 month ago
|
||
| bugherder | ||
Description
•