Closed Bug 2074579 Opened 2 months ago Closed 1 month ago

[wpt-sync] Sync PR 62869 - [masonry] Account for rule visibility in grid lanes

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
159 Branch
Tracking Status
firefox159 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 62869 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/62869
Details from upstream follow.

Javier Contreras <javiercon@microsoft.com> wrote:

[masonry] Account for rule visibility in grid lanes

Grid-lanes gap geometry did not record empty adjacent lanes, causing
around and between to paint rules that should be hidden.

The current proposal is to consider a gap segment as empty after if
there are no items in the next lane, empty before if there are no items
in the previous lane, and empty both if there are no items in either
lane. [1]

We use the already built logic that determines blocked states for
segments, using vectors of occupants in the track before the main gap
being processed and after the main gap being processed

[1] https://github.com/w3c/csswg-drafts/issues/14489.

Bug: 343257585
Change-Id: I6d5e9aecf145972c66593f90bfa3ade4a7204eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8428244
Reviewed-by: Alison Maher \<almaher@microsoft.com>
Commit-Queue: Javier Contreras \<javiercon@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1702588}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 112 tests

Status Summary

Firefox

PASS: 4[GitHub] 6[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 11[GitHub] 106[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 4
FAIL: 11

Safari

PASS: 5
FAIL: 10

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 159 Branch
You need to log in before you can comment on or make changes to this bug.