2074671 - Integrate new messaging and UI for mini window selection

Status: NEW

(Firefox :: Tabbed Browser, task)

Comment 1

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 2074671 - Offer a Mini Window chooser on the Screenshots overlay. r=mconley

Mini window mode reused the Screenshots overlay verbatim, which left it
telling the user to take a screenshot and hiding the buttons panel outright.

Give the overlay its own heading and instructions, and put the panel back with
two choices in place of the save buttons: move the selection the user draws,
or move the whole tab. Selection is the default, so dragging straight away
does what the panel's first option would have.

Also give the toolbar button its own icon.

Comment 2

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 2074671 - Update toolbar hiding behavior and make urlbar editable on full tab mini windows. r=mconley

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7c514e2cc83e
https://hg.mozilla.org/integration/autoland/rev/244d1ee3e507
Offer a Mini Window chooser on the Screenshots overlay. r=mconley,fluent-reviewers,desktop-theme-reviewers,emilio,flod,jhirsch
https://github.com/mozilla-firefox/firefox/commit/7249cc55bf93
https://hg.mozilla.org/integration/autoland/rev/fcb57108577e
Update toolbar hiding behavior and make urlbar editable on full tab mini windows. r=mconley,desktop-theme-reviewers,urlbar-reviewers,dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/eaa6686b1c42
https://hg.mozilla.org/integration/autoland/rev/eac3b513e54a
Revert "Bug 2074671, Bug 2075266, Bug 2074672 - Update toolbar hiding behavior and make urlbar editable on full tab mini windows. r=mconley,desktop-theme-reviewers,urlbar-reviewers,dao" for causing failures at browser_chooser_panel.js.

Comment 5

[Atila Butkovits]

Backed out for causing failures at browser_chooser_panel.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/eac3b513e54aeced255ef749dc7735b6c617ac95

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=fcb57108577e56245b5b654f7283f199fb649525&selectedTaskRun=BFcpHQ_8QWKjbAhqwskWJQ.0

Failure log:https://treeherder.mozilla.org/logviewer?job_id=596068127&repo=autoland&task=BFcpHQ_8QWKjbAhqwskWJQ.0&lineNumber=5681

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cfdad434a148
https://hg.mozilla.org/integration/autoland/rev/e59ce928d217
Offer a Mini Window chooser on the Screenshots overlay. r=mconley,fluent-reviewers,desktop-theme-reviewers,emilio,flod,jhirsch
https://github.com/mozilla-firefox/firefox/commit/1d51b017b5fb
https://hg.mozilla.org/integration/autoland/rev/227f214b46e0
Update toolbar hiding behavior and make urlbar editable on full tab mini windows. r=mconley,desktop-theme-reviewers,urlbar-reviewers,dao

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b478a70dbe9b
https://hg.mozilla.org/integration/autoland/rev/5fafebaaa5bc
Revert "Bug 2074671, Bug 2074672, Bug 2075266 - Update toolbar hiding behavior and make urlbar editable on full tab mini windows. r=mconley,desktop-theme-reviewers,urlbar-reviewers,dao" for causing bc and TV tests failures at chooser_panel.js

Comment 8

[Silaghi Andreea]

Backed out for causing bc and TV tests failures at chooser_panel.js
Backout Link
Push with failures
bc backfills
Failure Log
bc2
failure log
Failure line's
TEST-UNEXPECTED-FAIL | browser/components/miniwindow/test/browser/browser_chooser_panel.js | test_move_selection_dismisses_the_chooser - Uncaught exception in test - waiting for focus to land on the overlay - timed out after 50 tries.

TEST-UNEXPECTED-FAIL | browser/components/miniwindow/test/browser/browser_overlap.js | test_second_mini_window_avoids_the_first - the second mini window opened clear of the first - false == true