Closed Bug 2074781 Opened 2 months ago Closed 1 month ago

[wpt-sync] Sync PR 62874 - Reduce WPT flakiness for CSS-based images

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
159 Branch
Tracking Status
firefox159 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 62874 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/62874
Details from upstream follow.

Hoch Hochkeppel <mhochk@microsoft.com> wrote:

Reduce WPT flakiness for CSS-based images

These tests are passing the vast majority of the time, but still failing
with some regularity due to a race between the image being loaded and
the framework capturing the rendered pixels. This change eliminates that
race by adding preloads and explicitly having the test wait for them.

An earlier change for page-background-image-print (crrev.com/c/8334591)
found the preload alone was enough to remove the flakiness, but further
investigation into tests failing a greater percentage of the time (e.g.
page-background-005-print) found the preload was only a partial fix, and
corrected my previous misunderstanding that the test harness waited for
preloads automatically.

Efforts to fix this broadly at the harness level instead are tracked by
crbug.com/564820079

Bug: None
Change-Id: Idfbbcb1d5298072b64f1903f518704f9c00482e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8433968
Reviewed-by: Kurt Catti-Schmidt \<kschmi@microsoft.com>
Commit-Queue: Hoch Hochkeppel \<mhochk@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1702812}

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 258 tests and 15 subtests

Status Summary

Firefox

OK : 22
PASS : 1[GitHub] 9[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 140[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 142[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 262[Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-opt] 263[Gecko-linux2404-64-debug, Gecko-windows11-64-25h2-debug]
FAIL : 4[GitHub] 33[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 134[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
TIMEOUT: 2[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug] 3[Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-opt]
ERROR : 1

Chrome

PASS : 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 159 Branch
You need to log in before you can comment on or make changes to this bug.