2074830 - Partitioned tracker cookie reads are reported as allowed tracker cookies with the ContentClassifier

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Tim Huang[:timhuang]]

A tracker that reads cookies from its partitioned jar gets a STATE_COOKIES_LOADED_TRACKER event in the content blocking log, as if its cookies had been allowed unpartitioned.

The root cause of the behavior change for the ContentClassifier is that the ContentBlockingNotifier emits ContentBlocking events according to the tracking sub-category flags. However, the ContentClassifier only sets the generic tracking flag because we use a combined tracker list for the ContentClassifier.

We should change our ContentBlocking notification code path to emit STATE_COOKIES_LOADED event when a tracker reads partitioned cookies. This aligns with the current behavior of URLClassifier. To do so, we need to let the ContentBlockingNotifier know it's a tracker that reads partitioned cookies.

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 2074830 - Stop reporting partitioned tracker cookie reads as allowed tracker cookies. r?emz!,#cookie-reviewers!

This patch changes the cookie service to pass the partition reason to the
accepted-cookie notification, and changes NotifyBlockingDecision to treat
an allow decision carrying STATE_COOKIES_PARTITIONED_TRACKER as partitioned
access, so it no longer emits STATE_COOKIES_LOADED_TRACKER.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/96b92d51b1a1
https://hg.mozilla.org/integration/autoland/rev/a65ceb68db96
Stop reporting partitioned tracker cookie reads as allowed tracker cookies. r=emz,cookie-reviewers,valentin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3e28c5a0e5f0
https://hg.mozilla.org/integration/autoland/rev/d233359870dd
Revert "Bug 2074830 - Stop reporting partitioned tracker cookie reads as allowed tracker cookies. r=emz,cookie-reviewers,valentin" for causing bc failures @ browser_socialtracking.js

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_socialtracking.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d233359870ddb556619357aa2287ef896b3d5491

Push with failures

Failure log ->TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_socialtracking.js | Content blocking log should be as expected

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b641180e6138
https://hg.mozilla.org/integration/autoland/rev/e838f550771d
Stop reporting partitioned tracker cookie reads as allowed tracker cookies. r=emz,cookie-reviewers,valentin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7b83edd9b350
https://hg.mozilla.org/integration/autoland/rev/af56a4add9f5
Revert "Bug 2074830 - Stop reporting partitioned tracker cookie reads as allowed tracker cookies. r=emz,cookie-reviewers,valentin" for causing bc failures @ browser_protectionsUI_socialtracking.js

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_protectionsUI_socialtracking.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/af56a4add9f5cad6051ac0d46d610d07ac35390f

Push with failures

Failure log ->TEST-UNEXPECTED-FAIL | browser/base/content/test/browser-protectionsUI/browser_protectionsUI_socialtracking.js

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e14aade4c733
https://hg.mozilla.org/integration/autoland/rev/cce1dd8f1d7a
Stop reporting partitioned tracker cookie reads as allowed tracker cookies. r=emz,cookie-reviewers,valentin

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/cce1dd8f1d7a

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/cce1dd8f1d7a