[wpt-sync] Sync PR 62884 - Preserve negative timestamps in AudioDiscardHelper
Categories
(Core :: Audio/Video: Web Codecs, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox159 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Attachments
(1 file)
|
447.61 KB,
text/plain
|
Details |
Sync web-platform-tests PR 62884 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/62884
Details from upstream follow.
Dale Curtis <dalecurtis@chromium.org> wrote:
Preserve negative timestamps in AudioDiscardHelper
Update AudioDiscardHelper to preserve negative initial timestamps
instead of clamping them to zero. As initial pre-skip frames and front
discard padding are removed from buffers starting with negative
timestamps, AudioDiscardHelper advances timestamp_helper_ forward
accordingly.For Opus decoding via FFmpeg, clamp initial negative timestamps to zero
in FFmpegAudioDecoder when decoder delay discarding is active to avoid
duplicate pre-roll sample trimming.Add unit tests in AudioDiscardHelperTest covering negative timestamp
handling across decoder delay reset, initial pre-skip discard, and front
discard padding. Remove obsolete WebCodecs failure expectations for
codecs where negative timestamp decoding tests now pass.Bug: 512772321
Change-Id: I67e6cb5ec655f2cc4c4391da0d07762ef67c9013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8103062
Reviewed-by: Thomas Guilbert \<tguilbert@chromium.org>
Commit-Queue: Thomas Guilbert \<tguilbert@chromium.org>
Auto-Submit: Dale Curtis \<dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1703084}
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 1•2 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=96120
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 2•2 months ago
|
||
CI Results
Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 258 tests and 6 subtests
Status Summary
Firefox
OK : 26[GitHub] 175[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-debug-isolated-process-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 239[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 241[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 250[GitHub] 1624[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-debug-isolated-process-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 2242[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 2336[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL : 10[GitHub] 353[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-debug-isolated-process-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 364[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PRECONDITION_FAILED: 23[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 121[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 517[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-debug-isolated-process-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
ERROR : 4[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 12[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-debug-isolated-process-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
NOTRUN : 40
Chrome
OK : 22
PASS : 198
FAIL : 22
ERROR : 4
NOTRUN : 40
Safari
OK : 22
PASS : 210
FAIL : 10
ERROR : 4
NOTRUN : 40
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
(See attachment for full changes)
Comment 4•1 month ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/eaf5e73793ce
https://hg.mozilla.org/mozilla-central/rev/d3fbf6a25c18
Comment 5•1 month ago
|
||
| bugherder | ||
Description
•