Closed Bug 2074898 Opened 1 month ago Closed 1 month ago

Divider line appears between the bottom address bar and the tab strip or tab group strip above it

Categories

(Firefox for Android :: Tabs, defect)

All
Android
defect

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: calu, Assigned: petru)

References

Details

(Whiteboard: [fxdroid][android-core])

Attachments

(1 external file)

When the address bar is positioned at the bottom and a tab strip or tab group strip is shown directly above it, the address bar's top border renders as a divider line between the two bars. The bars also do not share a theme, so the line reads as a visible break in the UI.

Expected: no divider line between the bars. The top border should only appear when the address bar is on its own, not when a tab strip or tab group strip sits directly above it.

Until recently the single navigation bar or bottom toolbar were known to be the
top most bars shown at the bottom of the screens so they were hardcoded to show
a top divider.
Now it is possible for the tab strip or tab groups strip to be shown on top of
them so their divider should not be shown in favor of a new one supported by the
new strips.

Assignee: nobody → petru
Status: NEW → ASSIGNED
Pushed by plingurar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ce2c92f66775 https://hg.mozilla.org/integration/autoland/rev/8f751b38b129 Ensure bottom chrome dividers are shown on top of the top most bar r=android-reviewers,calu
Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/25f17001b54b https://hg.mozilla.org/integration/autoland/rev/383353e5535d Revert "Bug 2074898 - Ensure bottom chrome dividers are shown on top of the top most bar r=android-reviewers,calu" for causing fenix failures.

Backed out for causing fenix failures.

Flags: needinfo?(petru)
Pushed by plingurar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/39f70188c9ed https://hg.mozilla.org/integration/autoland/rev/e1eab6b814ae Ensure bottom chrome dividers are shown on top of the top most bar r=android-reviewers,calu
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
Flags: needinfo?(petru)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: