Closed Bug 2075022 Opened 1 month ago Closed 1 month ago

Sync clients should adopt engine sync IDs from meta/syncids instead of resetting

Categories

(Firefox :: Sync, task)

task

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox-esr153 160+ fixed
firefox158 --- wontfix
firefox159 --- wontfix
firefox160 + fixed

People

(Reporter: skhamis, Assigned: skhamis)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsync-])

Attachments

(2 external files, 2 obsolete files)

In the patches enabling per-device Sync (bug 2072034) It will stop per-device clients from creating entries in meta/global's engines, because legacy clients treat that map as the account's enabled engines. Per-device clients keep each engine's shared {version, syncID} in a separate storage/meta/syncids record instead.

When a legacy (pre per-device) client enables an engine that has no engines entry, it calls resetSyncID() and makes a new sync ID. Every per-device device then sees a new generation and resets that engine, which means a full re-sync. No data is lost, but it happens every time an unpatched client enables an engine.

We'll need to make legacy clients read meta/syncids first. If it has an entry for the engine that matches the account's global syncID and the engine's version, the client publishes that {version, syncID} to meta/global and skips the reset. Otherwise nothing changes. The client only reads the record, never writes it.

On accounts with no meta/syncids, which is every account today, behavior is unchanged. The patch doesn't depend on the per-device Sync patches. The more legacy clients have it by the time per-device Sync launches, the fewer resets per-device devices will see, so we'll probably want to uplift it as far as possible, including ESR.

Assignee: nobody → skhamis
Status: NEW → ASSIGNED
Whiteboard: [fxsync-]
Pushed by skhamis@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/079656e66991 https://hg.mozilla.org/integration/autoland/rev/a7b82073584d Adopt engine syncIDs from meta/syncids instead of resetting r=markh,sync-reviewers
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch

[Tracking Requested - why for this release]:

See Also: → 2080694

It's not clear what you want to do here. Can you please clarify?

Flags: needinfo?(skhamis)
Attachment #9659150 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: With per device syncing coming to sync. The more clients that get this patch means less re-uploading of syncing data if they have both pre and post per-device syncing devices.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: medium
  • Explanation of risk level: This patch does nothing by itself until a device with per-device-syncing gets added to the account (a pref we will turn on eventually). Largely this patch will be invisible to users. Per device syncing will be QA'd and have automated testing against this patch before it goes out.
  • String changes made/needed?: N/A
  • Is Android affected?: no
Attachment #9659151 - Flags: approval-mozilla-esr153?

firefox-esr153 Uplift Approval Request

  • User impact if declined/Reason for urgency: With per device syncing coming to sync. The more clients that get this patch means less re-uploading of syncing data if they have both pre and post per-device syncing devices.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: medium
  • Explanation of risk level: This patch does nothing by itself until a device with per-device-syncing gets added to the account (a pref we will turn on eventually). Largely this patch will be invisible to users. Per device syncing will be QA'd and have automated testing against this patch before it goes out.
  • String changes made/needed?: N/A
  • Is Android affected?: no

firefox-release Uplift Approval Request

  • User impact if declined/Reason for urgency: With per device syncing coming to sync. The more clients that get this patch means less re-uploading of syncing data if they have both pre and post per-device syncing devices.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: medium
  • Explanation of risk level: This patch does nothing by itself until a device with per-device-syncing gets added to the account (a pref we will turn on eventually). Largely this patch will be invisible to users. Per device syncing will be QA'd and have automated testing against this patch before it goes out.
  • String changes made/needed?: N/A
  • Is Android affected?: no
Attachment #9659152 - Flags: approval-mozilla-release?

Sorry I was waiting until the release happened to request uplifts, I've now requested the appropriate uplifts, just wasn't sure if there was extra work for ESR!

Flags: needinfo?(skhamis)

Is there a particular reason this needs to be uplifted all the way to Release instead of riding the 160 train?

Flags: needinfo?(skhamis)
Flags: in-testsuite+

Mainly just the more clients we can get this on the better experience for those accounts when per device syncing lands. Though I think uplifted all the way to release might be a bit overzealous and now that we're on the 2 week cycle. Uplifting to beta and ESR will probably be fine and should coincide with the release of Per device syncing in 160. Let me know what steps I should do to cancel the release uplift specifically!

Flags: needinfo?(skhamis)

Per Slack discussion, this should ride the trains and uplift to ESR153 next cycle.

Attachment #9659150 - Attachment is obsolete: true
Attachment #9659150 - Flags: approval-mozilla-beta?
Attachment #9659152 - Attachment is obsolete: true
Attachment #9659152 - Flags: approval-mozilla-release?
Attachment #9659151 - Flags: approval-mozilla-esr153? → approval-mozilla-esr153+
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: