2075298 - Include terminator timeout value for the "moz:shutdownTimeout" capability

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

On bug 2074099 the preference toolkit.asyncshutdown.crash_timeout_additional_wait was added to all.js with a default value of 10. We should add this value on top of the already used toolkit.asyncshutdown.crash_timeout value for the moz:shutdownTimeout capability.

This can then correctly be picked up by geckodriver on bug 1443922 to not force-kill Firefox too early.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Jens, just to verify before I attach a patch to this bug. Is it enough to wait crash_timeout + crash_timeout_additional_wait, or should we add some more seconds on top of that sum to not still kill the Firefox process too early?

Comment 2

[Jens Stutte [:jstutte]]

I'd probably add some buffer on top.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 2075298 - [remote] Include terminator timeout value for the "moz:shutdownTimeout" capability.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c6e09026e4f9
https://hg.mozilla.org/integration/autoland/rev/9d3cd9fae279
[remote] Include terminator timeout value for the "moz:shutdownTimeout" capability. r=webdriver-reviewers,Sasha,jstutte

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9d3cd9fae279

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As I just noticed the 3s as extra buffer that I added seem to be too less even for opt builds. We still kill Firefox and miss the crash report from the shutdown hang:

https://treeherder.mozilla.org/logviewer?job_id=601957691&repo=try&task=Ld627C9NSg-0B7fbVIGS0w.0&lineNumber=148276-148279

We should increase the number maybe to 10s to be on the safe side. I'll trigger some additional try jobs to see which value might be optimal.