2075401 - "Phabricator Error: Validation errors" from `moz-phab submit` should display the revision

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

Follow-up to bug 2060484, which made moz-phab reorg name the revision when a transaction fails. moz-phab submit still reports errors from differential.revision.edit without saying which revision in the stack they belong to:

Phabricator Error: Validation errors:
  - You can not request review of this revision because it has already been closed. You can only request review of open revisions.

With a multi-commit stack, I can't easily tell which revision is closed.

Expected: prefix the error with the revision, e.g.

D314841: Phabricator Error: Validation errors:
  - You can not request review of this revision because it has already been closed. ...

moz-phab abandon has the same gap (mozphab/commands/abandon.py).

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 2075401 - submit: name the revision when updating it fails r=sheehan

differential.revision.edit errors don't mention which revision they
belong to, so a failing moz-phab submit on a stack reported e.g.

Phabricator Error: Validation errors:
  - You can not request review of this revision because it has
    already been closed.

leaving the user to work out which of the stack's revisions was meant.

Prefix the error raised while updating an existing revision with its
ID, as bug 2060484 did for moz-phab reorg.

Comment 2

[BMO Github Automation]

Authored by https://github.com/sylvestre
https://github.com/mozilla-conduit/review/commit/67a571d9d896c62eb0bd7ec4011824e9974d2854
[main] Bug 2075401 - submit: name the revision when updating it fails r=sheehan

(via GitHub webhook, authenticated as shared-secret)