Closed Bug 2075643 Opened 1 month ago Closed 1 month ago

Link the macOS OpenH264 plugin with lld instead of the cctools-port ld64

Categories

(Firefox Build System :: Task Configuration, task)

task

Tracking

(firefox159 fixed)

RESOLVED FIXED
159 Branch
Tracking Status
firefox159 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

Attachments

(1 external file)

The macOS OpenH264 plugin tasks still link with the cctools-port ld64, which cannot read the .tbd stubs of newer macOS SDKs, so they stand in the way of the SDK 27 update in bug 2072073. Every other macOS toolchain already links with lld.

The plugin target links with the C++ compiler and runs no other cctools tool. For the darwin targets, -fuse-ld=lld in LDFLAGS is enough, and the linux64-cctools-port fetch can be dropped from both mac tasks. The -mmacosx-version-min values stay as they are, because new plugin builds also ship to ESR users.

The cctools-port ld64 cannot read the .tbd stubs of newer macOS SDKs, while every other macOS toolchain
already links with lld. The plugin target links with the C++ compiler and runs no other cctools tool, so the
cctools fetch goes away as well.

Pushed by rvandermeulen@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8af047a0eeec https://hg.mozilla.org/integration/autoland/rev/7a0ab25eb627 Link the macOS OpenH264 plugin with lld instead of the cctools-port ld64. r=firefox-build-system-reviewers,ahochheiden
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 159 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: