Closed Bug 2075696 Opened 1 month ago Closed 1 month ago

Add support to ffvpx to use MediaCodec FLAC/Opus/Vorbis for EME playback

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

All
Android
enhancement

Tracking

()

RESOLVED FIXED
159 Branch
Tracking Status
firefox159 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

References

(Blocks 1 open bug, )

Details

Attachments

(2 external files)

We currently advertise support for Opus/FLAC/Vorbis for EME playback:
https://searchfox.org/firefox-main/rev/3682546ac2c02610537306ca16849de2c24aea45/dom/media/eme/KeySystemConfig.cpp#162-165,172-175

But we don't implement this path in ffvpx as ffmpeg doesn't supply the necessary hooks. We need to implement this for the EME playback path only, as otherwise we prefer our software implementations built into ffvpx.

I added a more complete patch to https://github.com/aosmond/FFmpeg/commit/47c92b0bb3946257636d883e7fc8186406419b75 which contains tests which I ran against the Android emulator.

Our only implementation for AAC is the MediaCodec NDK, and our pure
software encoders do not support decrypting as that also requires
the NDK.

This will allow EME playback for content encrypting audio of these
types.

See Also: → 2075734
See Also: → 2075870
Pushed by aosmond@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b2c191e67a00 https://hg.mozilla.org/integration/autoland/rev/c20566c207d1 Part 1. Only allow MediaCodec NDK audio decoders if using a CDM or for AAC. r=media-playback-reviewers,jolin https://github.com/mozilla-firefox/firefox/commit/4c76f7bf28b0 https://hg.mozilla.org/integration/autoland/rev/4b843c27d0df Part 2. Add Opus/FLAC/Vorbis support to ffvpx for MediaCodec NDK. r=media-playback-reviewers,jolin
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 159 Branch
QA Whiteboard: [qa-triage-done-c160/b159]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: