Remove version 157 train-hop guard for the layout_name newtab_content extra key
Categories
(Firefox :: New Tab Page, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox160 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(1 external file)
Bug 2058284 added layout_name as an extra_key to the newtab_content impression and click events in Firefox 157. Extra key additions are schema changes in browser/components/newtab/metrics.yaml, which rides the trains and cannot train-hop, so a train-hopped XPI on an older host would send a key the platform schema does not know about and trigger a Glean error. lib/NewTabContentPing.sys.mjs therefore deletes result.layout_name when AppConstants.MOZ_APP_VERSION is below 157.0a1.
We've already merged Firefox 157 to the release repository, and we're not going to be train-hopping any new XPIs to 156 and under, so this shim can be removed now. Drop that version check, the delete result.layout_name it guards, and its @backward-compat { version 157 } comment.
Important: the adjacent guard in the same function that deletes result.variant_id and result.source_section_id must NOT be removed with it. Those extra keys came from bug 2070362, which shipped in 158, not 157 - see bug 2075682, which corrects that guard's threshold and tag. Only the layout_name guard is covered by this bug.
Shim introduced in bug 2058284.
Comment 1•1 month ago
|
||
Firefox 157 has merged to release and no new XPIs will train-hop to 156 or older, so the @backward-compat { version 157 } shim in NewTabContentPing.sanitizeEventData that deleted layout_name on older hosts is no longer needed.
The separate @backward-compat { version 158 } guard for variant_id / source_section_id (from bug 2070362) stays as it is.
Updated•1 month ago
|
Updated•1 month ago
|
Comment 3•29 days ago
|
||
| bugherder | ||
Updated•22 days ago
|
Description
•