Closed Bug 2075717 Opened 1 month ago Closed 29 days ago

Remove version 157 train-hop guard for the layout_name newtab_content extra key

Categories

(Firefox :: New Tab Page, task)

task

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(1 external file)

Bug 2058284 added layout_name as an extra_key to the newtab_content impression and click events in Firefox 157. Extra key additions are schema changes in browser/components/newtab/metrics.yaml, which rides the trains and cannot train-hop, so a train-hopped XPI on an older host would send a key the platform schema does not know about and trigger a Glean error. lib/NewTabContentPing.sys.mjs therefore deletes result.layout_name when AppConstants.MOZ_APP_VERSION is below 157.0a1.

We've already merged Firefox 157 to the release repository, and we're not going to be train-hopping any new XPIs to 156 and under, so this shim can be removed now. Drop that version check, the delete result.layout_name it guards, and its @backward-compat { version 157 } comment.

Important: the adjacent guard in the same function that deletes result.variant_id and result.source_section_id must NOT be removed with it. Those extra keys came from bug 2070362, which shipped in 158, not 157 - see bug 2075682, which corrects that guard's threshold and tag. Only the layout_name guard is covered by this bug.

Shim introduced in bug 2058284.

Firefox 157 has merged to release and no new XPIs will train-hop to 156 or older, so the @backward-compat { version 157 } shim in NewTabContentPing.sanitizeEventData that deleted layout_name on older hosts is no longer needed.

The separate @backward-compat { version 158 } guard for variant_id / source_section_id (from bug 2070362) stays as it is.

Assignee: nobody → mconley
Status: NEW → ASSIGNED
Attachment #9648888 - Attachment description: Bug 2075717 - Remove the version 157 train-hop guard for layout_name in NewTabContentPing. → Bug 2075717 - Remove the version 157 train-hop guard for layout_name in NewTabContentPing. r?ini!
Pushed by mconley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3cb110a75b11 https://hg.mozilla.org/integration/autoland/rev/26cd2649e855 Remove the version 157 train-hop guard for layout_name in NewTabContentPing. r=ini
Status: ASSIGNED → RESOLVED
Closed: 29 days ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
QA Whiteboard: [qa-triage-done-c161/b160]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: