Closed Bug 2076295 Opened 1 month ago Closed 1 month ago

Mini window's are not always accurate in their crop

Categories

(Firefox :: Mini Window, defect, P1)

defect

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: hsohaney, Assigned: hsohaney)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fide-engagement])

Attachments

(4 external files, 1 obsolete file)

Since we just translate the page around after laying out - sticky elements on the page are lost.

Assignee: nobody → hsohaney
Status: NEW → ASSIGNED
Attachment #9649798 - Attachment description: Bug 2076295 - Switch from pure translation to a scroll and transform to frame cropped mini windows. r=mconley → Bug 2076295 - Switch from layout viewport to visual viewport and remove unnecessary child actor queries. r=mconley
Component: Tabbed Browser → Mini Window
Attachment #9649798 - Attachment is obsolete: true
Whiteboard: [fide-engagement]
Blocks: 2080028
Attachment #9655388 - Attachment description: Bug 2076295 - fix zoom clamping issues when using the mobile viewport manager. r=emilio → Bug 2076295 - Set minimum zoom for mini windows to 0.1. r=emilio
Blocks: 2080223
Pushed by hsohaney@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1a6824a111b3 https://hg.mozilla.org/integration/autoland/rev/8d0871e8c42d Frame cropped mini windows by zooming the visual viewport with APZ instead of a layout transform. r=emilio,webidl,layout-reviewers,mconley,smaug,hiro,botond https://github.com/mozilla-firefox/firefox/commit/e644571fd62b https://hg.mozilla.org/integration/autoland/rev/fbeec5a5d77a Set minimum zoom for mini windows to 0.1. r=emilio,layout-reviewers https://github.com/mozilla-firefox/firefox/commit/e2e552b99230 https://hg.mozilla.org/integration/autoland/rev/95715e6a5368 tests for framing using apz. r=emilio,layout-reviewers
Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f9c62290c4ce https://hg.mozilla.org/integration/autoland/rev/9ae62aee0553 Revert "Bug 2076295 - tests for framing using apz. r=emilio,layout-reviewers" for causing bc failures @browser_framing.js.

Backed out for causing bc failures @browser_framing.js.

Flags: needinfo?(hsohaney)
Pushed by hsohaney@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/bf1de2fa7c27 https://hg.mozilla.org/integration/autoland/rev/af7c175a5c6e Frame cropped mini windows by zooming the visual viewport with APZ instead of a layout transform. r=emilio,webidl,layout-reviewers,mconley,smaug,hiro,botond https://github.com/mozilla-firefox/firefox/commit/094cddd552ba https://hg.mozilla.org/integration/autoland/rev/a9df2cd1fd14 Set minimum zoom for mini windows to 0.1. r=emilio,layout-reviewers,hiro https://github.com/mozilla-firefox/firefox/commit/5940e568d5b5 https://hg.mozilla.org/integration/autoland/rev/b537989367d1 tests for framing using apz. r=emilio,layout-reviewers https://github.com/mozilla-firefox/firefox/commit/19603a862bb6 https://hg.mozilla.org/integration/autoland/rev/e9bf1b4e8e0d Account for classic scrollbars in the viewport size override and framing tests. r=emilio,layout-reviewers
Flags: needinfo?(hsohaney)
Regressions: 2083007
QA Whiteboard: [qa-triage-done-c161/b160]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: