[Sync] Setting the policy up via visual editor no longer allows to lock an unselected value
Categories
(Enterprise Products :: Console, defect)
Tracking
(Not tracked)
People
(Reporter: lburuian, Assigned: julienw)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(2 files, 1 external file)
Found in
- FxE version: 157.0 (20260925115502)
- Console version: commit: 225cc493fcce9b1b5d6b94106c86ee1e370a81b7, v0.6.1
Affected environment
- Staging
Tested platforms
- Affected platforms: All
Preconditions
- Have FxE installed
Steps to reproduce
- Go to the stage Admin console and log in
- Search for the Sync policy and set it up, leaving some options unchecked (for example Bookmarls, Addreses).
NOTE: Make sure you check the Enabled checkbox - Lock the policy by checking the Locked parameter and Save it
- In the client, check the Sync options.
Expected result
- The parameters left unchecked are NOT enabled in the client and ALL the values are LOCKED
Actual result
- The parameters left unchecked are NOT enabled in the client but the values are NOT LOCKED, althoug the polcy setup dictates this
Additional notes
- As a conclusion, the admin cannot set sync values as BOTH FALSE (by leaving them unchecked) and LOCKED
- Also, the values left unchecked do not appear in about:policies as FALSE. Using this workaround fixes the problem.
| Assignee | ||
Comment 2•1 month ago
|
||
I think this will also be fixed by https://github.com/mozilla/enterprise-console/pull/447
QA note: the issue seems to apply to the Security Logging policy as well, in the sense that the side settings like UrlLogging or FileLogging dont`t get registered when left unchanged, you need select something else first and then revert back to default values, for them to be registered as option in the JSON file and set up the corresponding flags in the client.
The same for Extension Settings.
This seems to be a general validation issue in the new policy eding experience.
Comment 4•1 month ago
|
||
Note for us to check cases where nothing gets set in the JSON until you interact with the dropdown, and if we need a "Select a value" placeholder text, i.e., https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/select#try_it
| Assignee | ||
Comment 5•1 month ago
|
||
Yes, that's what the aforementioned patch does.
Hello,
The current fix in the console does not really solve the problem for the Sync policy. Leaving the values as Not set is now the equivalent of leaving the checkbox unchecked in the old UI. That means the same thing: although you lock Sync via policy, the NOT set values are not blocked, as they are not displayed in the JSON.
This actually makes matters worse as now the Admin can intentionally set a value to Not set and reproduces the issue more easily than before.
For this issue to be fixed, the Sync policy should not allow values to be left as Not set, just True or False. Maybe Not set could become "Select a value" and throw an error when trying to save with any of the parameter not set/ without selecting a value.
Please let us know your thoughts on this.
Thank you.
| Assignee | ||
Comment 7•1 month ago
|
||
In my opinion this works as expected: when the value is not set, then it's not locked. If the admin wants a value locked, they need to set a value to true or false.
The evidence that this works as expected is that Firefox doesn't reject the policy.
If we want to change that, we can make the values required, which would make them work like you suggest, but I fear this would be incompatible with existing policies.
Hey Brian, what are your thoughts?
| Assignee | ||
Comment 8•1 month ago
|
||
Also to be clear, what the patch did is that it's now obvious that "false" is actually "do not sync this thing", while previously it wasn't clear between "do not sync" and "do not set a value".
Comment 9•1 month ago
|
||
I think the fix here is to create a custom Sync policy form (editor), because Enabled and Locked are different from the rest of the options here and there's no way to express that in the schema. Do you agree? If so, we can track it in a new ticket.
Updated•1 month ago
|
| Assignee | ||
Comment 11•7 days ago
|
||
Gonna close this bug. The remaining work will be in bug 2079738.
Description
•