207643 - Unnecessary focus() calls in ComposerCommands.js

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Ere Maijala (slow)]

I believe that many of the focus() commands after displaying a dialog of some
kind in ComposerCommands.js are not necessary anymore now that the focus is
correctly restored even when closing nested modal dialogs.

Comment 1

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 2

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420

Comment 3

[Karsten Düsterloh]

Still worth trying.

Comment 4

[Javi Rueda :javirid]

Attachment: patch

The call to focus() after SaveDocument is because the dialog is opened inside SaveDocument function.

I believe that I have not removed any needed call nor I have left behind any removable one.

Comment 5

[[e-mail]]

Comment on attachment 622887 [details] [diff] [review]
patch

I agree that none of these appear to be needed. I didn't look for any others.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/ff3e0d0b3973