2076535 - The glean-parser linter doesn't report metrics.yaml schema validation errors

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Julien Cristau [:jcristau]]

A metrics.yaml with, e.g., an unknown property in a metric passes mach lint -l glean-parser (and the source-test-mozlint-glean-parser job) with "0 problems", while the build fails to parse it.

glean_parser reports schema validation errors as blocks separated by lines of =, while the linter only turns lines starting with WARNING: or ERROR: (the glinter nits) into results, so validation errors are silently dropped.

Reporting those blocks as errors also uncovers that toolkit/crashreporter/crashping/static_metrics.yaml is linted together with generated_metrics.yaml, which contains the same metrics (glean_metrics.py merges them), so it needs to be excluded.

Comment 1

[Julien Cristau [:jcristau]]

Per bug 2076540, schema validation is on the critical path in particular for artifact builds, so I'm looking at skipping it there, relying on the linter to catch issues instead.

Comment 2

[Julien Cristau [:jcristau]]

Attachment: Bug 2076535 - Report schema validation errors from the glean-parser linter

glean_parser reports schema validation errors as blocks separated by
lines of "=", not as "WARNING:"/"ERROR:" lines like the glinter nits,
so the linter silently dropped them and passed files that fail
validation. Turn those blocks into lint errors too.

This uncovered that static_metrics.yaml is linted together with
generated_metrics.yaml, which contains the same metrics, so exclude it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/383d49004338
https://hg.mozilla.org/integration/autoland/rev/f38b03d1ea59
Report schema validation errors from the glean-parser linter r=linter-reviewers,janerik,sylvestre

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f38b03d1ea59