Add the `glean.flows_not_started` diagnostic counter
Categories
(Data Platform and Tools :: Glean: SDK, enhancement, P1)
Tracking
(Not tracked)
People
(Reporter: travis_, Assigned: travis_)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file, 1 external file)
|
5.66 KB,
text/plain
|
chutten
:
data-review+
|
Details |
Add a labeled counter, keyed by flow name, that is incremented when an entry event is recorded while no session is active, so the instance can't open. Depends on Bug 2077136 and the lifecycle Bug 2077138.
- Out-of-session, sent in the
metricsping. - Not incremented when the flow is disabled, or when the flow already has an active instance.
Label set: an open question on the meta. Dynamic labels are capped at 16 (MAX_LABELS), and a product with more flows than that would see the rest collapse into __other__. Because Bug 2077136 passes the registration through InternalConfiguration, the flow names are available in Glean::new_for_subprocess() where CoreMetrics::new() is called. A static label set can be built there without deferred construction, which makes it the simpler option.
The metric description should say the value shows the size of the problem, not a loss rate. It is sent in a different ping from the tagged events and glean.flow_end, on an unrelated schedule, so it can't be used as a numerator against them.
| Assignee | ||
Updated•3 days ago
|
| Assignee | ||
Updated•3 days ago
|
Comment 1•3 days ago
|
||
(via GitHub webhook, authenticated as shared-secret)
| Assignee | ||
Comment 2•3 days ago
|
||
Comment 3•3 days ago
|
||
Comment on attachment 9686491 [details]
data-review-request.txt
DATA COLLECTION REVIEW RESPONSE:
Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?
Yes.
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes. This collection can be controlled through the product's preferences.
If the request is for permanent data collection, is there someone who will monitor the data over time?
Yes, Travis Long and the Glean Team are responsible.
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Category 1, Technical.
Is the data collection request for default-on or default-off?
Default on for all channels.
Does the instrumentation include the addition of any new identifiers?
Yes, but they're locally-generated temporally-longitudinal UUIDs (ie, not useful as keys across datasets)
Is the data collection covered by the existing Firefox privacy notice?
Yes.
Does the data collection use a third-party collection tool?
No.
Result: datareview+
Description
•