Closed Bug 2077172 Opened 1 month ago Closed 17 days ago

Remove the socket process

Categories

(Core :: Networking, task, P2)

task

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: leggert, Assigned: leggert)

References

(Blocks 2 open bugs)

Details

(Keywords: perf-alert, Whiteboard: [necko-triaged])

Attachments

(31 external files, 3 obsolete files)

No description provided.
Assignee: nobody → leggert
Severity: -- → N/A
Priority: -- → P2
Whiteboard: [necko-triaged]
Summary: Remove the socket process → Remove networking from the socket process

Covers observer forwarding, the netwerk/base callers and the SSLTokensCache
load and clear forwarding.

Removes the connection manager, HTTP transaction, WebSocket connection,
alt-svc, AltService, activity distributor, throttle queue and data bridge
actors, stops creating nsHttpHandler in the socket process, and drops the
SocketToParent PerfStats metrics.

Removes the TRR service, native resolver override and proxy config lookup
actors, makes PDNSRequest messages one-directional, and drops the dead parent
branch of ChildDNSService::GetMyHostName.

Removes the PSM actors, ipcclientcerts, PSMIPCUtils.h and the PSM IPC types
they used.

Also collapses ProxyAutoConfigBase into ProxyAutoConfig.

Removes isLoadedBySocketProcess and resolvedInSocketProcess, forwards only the
prefs the socket process reads, and stops nsIOService implementing
nsIObserverService.

Makes HttpActivityArgs a plain C++ type and removes the nsHttpTransaction
observer.

Attachment #9653433 - Attachment description: WIP: Bug 2077172 - Add a browser test for the socket process telemetry scalar. r=#toolkit-telemetry-reviewers-rotation → Bug 2077172 - Add a browser test for the socket process telemetry scalar. r=#toolkit-telemetry-reviewers-rotation
Attachment #9653434 - Attachment description: WIP: Bug 2077172 - Remove socket process crash handling and parent-to-socket forwarding. r=#necko-reviewers → Bug 2077172 - Remove socket process crash handling and parent-to-socket forwarding. r=#necko-reviewers
Attachment #9653435 - Attachment description: WIP: Bug 2077172 - Remove HTTP networking from the socket process. r=#necko-reviewers → Bug 2077172 - Remove HTTP networking from the socket process. r=#necko-reviewers
Attachment #9653436 - Attachment description: WIP: Bug 2077172 - Remove the unused WebSocketConnection classes and fold WebSocketChannel helpers. r=#necko-reviewers → Bug 2077172 - Remove the unused WebSocketConnection classes and fold WebSocketChannel helpers. r=#necko-reviewers
Attachment #9653437 - Attachment description: WIP: Bug 2077172 - Remove DNS and TRR networking from the socket process. r=#necko-reviewers → Bug 2077172 - Remove DNS and TRR networking from the socket process. r=#necko-reviewers
Attachment #9653439 - Attachment description: WIP: Bug 2077172 - Remove PAC parsing from the socket process. r=#necko-reviewers → Bug 2077172 - Remove PAC parsing from the socket process. r=#necko-reviewers
Attachment #9653438 - Attachment description: WIP: Bug 2077172 - Remove TLS certificate verification and client auth from the socket process. r=keeler → Bug 2077172 - Remove TLS certificate verification and client auth from the socket process. r=keeler
Attachment #9653440 - Attachment description: WIP: Bug 2077172 - Remove nsIOService::UseSocketProcess and the state it gated. r=#necko-reviewers → Bug 2077172 - Remove nsIOService::UseSocketProcess and the state it gated. r=#necko-reviewers
Attachment #9653441 - Attachment description: WIP: Bug 2077172 - Remove dead socket process code from NetworkConnectivityService and unused ALLOW_IN_SOCKET_PROCESS entries. r=#necko-reviewers → Bug 2077172 - Remove dead socket process code from NetworkConnectivityService and unused ALLOW_IN_SOCKET_PROCESS entries. r=#necko-reviewers
Attachment #9653432 - Attachment description: WIP: Bug 2077172 - Remove the network_access_on_socket_process pref and the socketprocess_networking test mode. r=#necko-reviewers → Bug 2077172 - Remove the network_access_on_socket_process pref and the socketprocess_networking test mode. r=#necko-reviewers
Attachment #9653442 - Attachment description: WIP: Bug 2077172 - Remove unused socket process IPC code and includes. r=#necko-reviewers → Bug 2077172 - Remove unused socket process IPC code and includes. r=#necko-reviewers
Attachment #9653443 - Attachment description: WIP: Bug 2077172 - Collapse TRRServiceBase, HttpConnectionMgrShell and HttpTransactionShell into their implementations. r=#necko-reviewers → Bug 2077172 - Collapse TRRServiceBase, HttpConnectionMgrShell and HttpTransactionShell into their implementations. r=#necko-reviewers
Attachment #9653444 - Attachment description: WIP: Bug 2077172 - Update docs and comments that described networking in the socket process. r=#necko-reviewers → Bug 2077172 - Update docs and comments that described networking in the socket process. r=#necko-reviewers
Attachment #9653445 - Attachment description: WIP: Bug 2077172 - Remove IPC types and accessors that only served socket process networking. r=#necko-reviewers → Bug 2077172 - Remove IPC types and accessors that only served socket process networking. r=#necko-reviewers
Attachment #9653446 - Attachment description: WIP: Bug 2077172 - Remove the SSL tokens cache from the socket process. r=#necko-reviewers → Bug 2077172 - Remove the SSL tokens cache from the socket process. r=#necko-reviewers
Attachment #9653447 - Attachment description: WIP: Bug 2077172 - Initialize the TLS I/O layer helpers only in the parent process. r=keeler,#necko-reviewers → Bug 2077172 - Initialize the TLS I/O layer helpers only in the parent process. r=keeler,#necko-reviewers
Attachment #9653448 - Attachment description: WIP: Bug 2077172 - Stop allowing nsUDPSocket in the socket process and forwarding prefs it no longer reads. r=#necko-reviewers → Bug 2077172 - Stop allowing nsUDPSocket in the socket process and forwarding prefs it no longer reads. r=#necko-reviewers
Attachment #9653449 - Attachment description: WIP: Bug 2077172 - Stop forwarding connectivity to the socket process. r=#necko-reviewers → Bug 2077172 - Stop forwarding connectivity to the socket process. r=#necko-reviewers
Attachment #9653450 - Attachment description: WIP: Bug 2077172 - Remove the socket process branch from net_EnsurePSMInit. r=#necko-reviewers → Bug 2077172 - Remove the socket process branch from net_EnsurePSMInit. r=#necko-reviewers
Attachment #9653451 - Attachment description: WIP: Bug 2077172 - Fold AltSvcMappingValidator into AltSvcTransaction. r=#necko-reviewers → Bug 2077172 - Fold AltSvcMappingValidator into AltSvcTransaction. r=#necko-reviewers
Attachment #9653452 - Attachment description: WIP: Bug 2077172 - Replace DNSRequestBase and DNSRequestActor with concrete types. r=#necko-reviewers → Bug 2077172 - Replace DNSRequestBase and DNSRequestActor with concrete types. r=#necko-reviewers
Attachment #9653453 - Attachment description: WIP: Bug 2077172 - Only initialize and shut down SSLTokensCache in the parent process. r=#necko-reviewers → Bug 2077172 - Only initialize and shut down SSLTokensCache in the parent process. r=#necko-reviewers
Attachment #9653443 - Attachment is obsolete: true

:lars - you may already know this, but while looking into another bug, I found that the mochitest and xpcshell suites run with network.process.enabled=false and media.peerconnection.mtransport_process=false (from ensure_spi_disabled_on_all_but_spi).
It looks like the new test sets the pref itself, but the shipped socket process configuration is effectively only exercised by wpt and mochitest-media-spi, so a regression in what still runs there might not be caught.

(NI - just so you don't miss the comment.)

Flags: needinfo?(leggert)
Flags: needinfo?(leggert)
Attachment #9653433 - Attachment is obsolete: true
Attachment #9656538 - Attachment is obsolete: true
Summary: Remove networking from the socket process → Remove the socket process

Thanks Bob!

  • D333260 makes WebRTC media transport always run in the content process.
  • D333262 removes the socketprocess test variant, which includes mochitest-media-spi.
  • D333263 removes ensure_spi_disabled_on_all_but_spi, plus network.process.enabled and media.peerconnection.mtransport_process.
  • D331034 is now abandoned with the latest changes
Attachment #9658462 - Attachment description: Bug 2077172 - Run the Apple fast UDP datapath probe in a utility process. r=#necko-reviewers,#sandbox-reviewers → Bug 2077172 - Run the Apple fast UDP datapath probe in the parent process behind a crash guard. r=#necko-reviewers
Attachment #9658462 - Attachment description: Bug 2077172 - Run the Apple fast UDP datapath probe in the parent process behind a crash guard. r=#necko-reviewers → Bug 2077172 - Run the Apple fast UDP datapath probe in the parent process. r=#necko-reviewers
Pushed by leggert@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ef1513ac8119 https://hg.mozilla.org/integration/autoland/rev/20d66feb77d9 Remove the network_access_on_socket_process pref and the socketprocess_networking test mode. r=necko-reviewers,webcompat-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,taskgraph-reviewers,sessionstore-reviewers,tabbrowser-reviewers,profiler-reviewers,dom-storage-reviewers,omc-reviewers,sidebar-reviewers,firefox-style-system-reviewers,layout-reviewers,mconley,sthompson,jsudiaman,jhirsch,chumphreys,emilio,bomsy,cdupuis,canova,twisniewski,rpl,valentin,dimi,jari,aminomancer,ahal https://github.com/mozilla-firefox/firefox/commit/be05fd26be9b https://hg.mozilla.org/integration/autoland/rev/881ebb71fc68 Remove socket process crash handling and parent-to-socket forwarding. r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/a7929da8d4e9 https://hg.mozilla.org/integration/autoland/rev/9186fd0b7cad Remove HTTP networking from the socket process. r=necko-reviewers,ipc-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/c41d0b5b2ae0 https://hg.mozilla.org/integration/autoland/rev/ab24ed9e9162 Remove the unused WebSocketConnection classes and fold WebSocketChannel helpers. r=necko-reviewers,webrtc-reviewers,bwc,valentin https://github.com/mozilla-firefox/firefox/commit/287fc60ad561 https://hg.mozilla.org/integration/autoland/rev/3f5ff2880265 Remove DNS and TRR networking from the socket process. r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/b5889b65a4bc https://hg.mozilla.org/integration/autoland/rev/6824cfb1e200 Remove TLS certificate verification and client auth from the socket process. r=keeler,necko-reviewers,geckoview-reviewers,ipc-reviewers,owlish https://github.com/mozilla-firefox/firefox/commit/bf1efd6ce144 https://hg.mozilla.org/integration/autoland/rev/e5d7fea34bcf Remove PAC parsing from the socket process. r=kershaw https://github.com/mozilla-firefox/firefox/commit/ff39d564dcff https://hg.mozilla.org/integration/autoland/rev/f5a36c6b6759 Remove nsIOService::UseSocketProcess and the state it gated. r=necko-reviewers,kershaw https://github.com/mozilla-firefox/firefox/commit/d5084294333d https://hg.mozilla.org/integration/autoland/rev/343123327402 Remove dead socket process code from NetworkConnectivityService and unused ALLOW_IN_SOCKET_PROCESS entries. r=necko-reviewers,valentin,geckoview-reviewers,owlish https://github.com/mozilla-firefox/firefox/commit/675a9a5e1117 https://hg.mozilla.org/integration/autoland/rev/72e8657c5b7a Remove unused socket process IPC code and includes. r=necko-reviewers,ipc-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/e9ffdc5da844 https://hg.mozilla.org/integration/autoland/rev/b06cad832e75 Update docs and comments that described networking in the socket process. r=necko-reviewers,ipc-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/139e2b30163b https://hg.mozilla.org/integration/autoland/rev/9be1f7cd140e Remove IPC types and accessors that only served socket process networking. r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/f4928f7f3cf1 https://hg.mozilla.org/integration/autoland/rev/eb4c4484c6a4 Remove the SSL tokens cache from the socket process. r=necko-reviewers,kershaw https://github.com/mozilla-firefox/firefox/commit/7e202301cddf https://hg.mozilla.org/integration/autoland/rev/9471c2312e4c Initialize the TLS I/O layer helpers only in the parent process. r=keeler,necko-reviewers https://github.com/mozilla-firefox/firefox/commit/4dcbd01b31e0 https://hg.mozilla.org/integration/autoland/rev/a35b5bca693e Stop allowing nsUDPSocket in the socket process and forwarding prefs it no longer reads. r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/ed9308b15197 https://hg.mozilla.org/integration/autoland/rev/caca0d950a92 Stop forwarding connectivity to the socket process. r=necko-reviewers,kershaw https://github.com/mozilla-firefox/firefox/commit/3f0eb96d738a https://hg.mozilla.org/integration/autoland/rev/b53083ac7057 Remove the socket process branch from net_EnsurePSMInit. r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/9e9df8b5f230 https://hg.mozilla.org/integration/autoland/rev/a305eb99ca83 Fold AltSvcMappingValidator into AltSvcTransaction. r=necko-reviewers,kershaw https://github.com/mozilla-firefox/firefox/commit/ebcd726aad01 https://hg.mozilla.org/integration/autoland/rev/b88ede8e89c5 Replace DNSRequestBase and DNSRequestActor with concrete types. r=necko-reviewers,kershaw https://github.com/mozilla-firefox/firefox/commit/531af18a3225 https://hg.mozilla.org/integration/autoland/rev/c63200393e11 Only initialize and shut down SSLTokensCache in the parent process. r=necko-reviewers,kershaw https://github.com/mozilla-firefox/firefox/commit/c579d0a518af https://hg.mozilla.org/integration/autoland/rev/e124eaad5796 Rename the client certs object types used by remote PKCS#11 modules to Cryptoki names. r=keeler https://github.com/mozilla-firefox/firefox/commit/d413843dda09 https://hg.mozilla.org/integration/autoland/rev/930746805f84 Run the Apple fast UDP datapath probe in the parent process. r=ipc-reviewers,jesup,fluent-reviewers,nika,bolsson https://github.com/mozilla-firefox/firefox/commit/552864078bdd https://hg.mozilla.org/integration/autoland/rev/a9278b676ed7 Always run WebRTC media transport in the content process. r=webrtc-reviewers,sandbox-reviewers,bobowen,bwc https://github.com/mozilla-firefox/firefox/commit/742b6f512cb8 https://hg.mozilla.org/integration/autoland/rev/02d1bdc452ee Remove the media transport IPC and the socket process bridge. r=webrtc-reviewers,necko-reviewers,ipc-reviewers,bwc,valentin https://github.com/mozilla-firefox/firefox/commit/20b7b2066dec https://hg.mozilla.org/integration/autoland/rev/d30f0b8928a0 Remove the socketprocess test variant and the socketprocess_e10s manifest token. r=taskgraph-reviewers,ahal https://github.com/mozilla-firefox/firefox/commit/7f008e7c8dd4 https://hg.mozilla.org/integration/autoland/rev/b49188db8ce9 Stop launching the socket process and remove its code. r=keeler,necko-reviewers,sandbox-reviewers,ipc-reviewers,taskgraph-reviewers,chumphreys,jesup,ahal https://github.com/mozilla-firefox/firefox/commit/90fc8b740a6e https://hg.mozilla.org/integration/autoland/rev/6067c2f1c5ea Remove the socket process sandbox policies. r=sandbox-reviewers,ipc-reviewers,jld,bobowen,haik https://github.com/mozilla-firefox/firefox/commit/e4abbea577b4 https://hg.mozilla.org/integration/autoland/rev/da75c3698a30 Block the socket process DLL blocklist entries in all child processes. r=gstoll,win-reviewers https://github.com/mozilla-firefox/firefox/commit/a10e78282fc7 https://hg.mozilla.org/integration/autoland/rev/a68446036367 Remove the socket process type. r=nika,ipc-reviewers,geckoview-reviewers,fluent-reviewers,crashreporting-reviewers,chumphreys,bolsson,mac-reviewers,bradwerth https://github.com/mozilla-firefox/firefox/commit/1ea529855064 https://hg.mozilla.org/integration/autoland/rev/018c55895d48 Remove the socket process from the XPCOM process selectors. r=nika,necko-reviewers,geckoview-reviewers,win-reviewers,chumphreys,jesup,gstoll,valentin,mac-reviewers,bradwerth https://github.com/mozilla-firefox/firefox/commit/1298e77b1c0f https://hg.mozilla.org/integration/autoland/rev/2c032e405d58 Update docs and comments that described the socket process. r=necko-reviewers,ipc-reviewers,webrtc-reviewers,sandbox-reviewers,crashreporting-reviewers,chumphreys,jesup,bwc

https://hg.mozilla.org/mozilla-central/rev/20d66feb77d9
https://hg.mozilla.org/mozilla-central/rev/881ebb71fc68
https://hg.mozilla.org/mozilla-central/rev/9186fd0b7cad
https://hg.mozilla.org/mozilla-central/rev/ab24ed9e9162
https://hg.mozilla.org/mozilla-central/rev/3f5ff2880265
https://hg.mozilla.org/mozilla-central/rev/6824cfb1e200
https://hg.mozilla.org/mozilla-central/rev/e5d7fea34bcf
https://hg.mozilla.org/mozilla-central/rev/f5a36c6b6759
https://hg.mozilla.org/mozilla-central/rev/343123327402
https://hg.mozilla.org/mozilla-central/rev/72e8657c5b7a
https://hg.mozilla.org/mozilla-central/rev/b06cad832e75
https://hg.mozilla.org/mozilla-central/rev/9be1f7cd140e
https://hg.mozilla.org/mozilla-central/rev/eb4c4484c6a4
https://hg.mozilla.org/mozilla-central/rev/9471c2312e4c
https://hg.mozilla.org/mozilla-central/rev/a35b5bca693e
https://hg.mozilla.org/mozilla-central/rev/caca0d950a92
https://hg.mozilla.org/mozilla-central/rev/b53083ac7057
https://hg.mozilla.org/mozilla-central/rev/a305eb99ca83
https://hg.mozilla.org/mozilla-central/rev/b88ede8e89c5
https://hg.mozilla.org/mozilla-central/rev/c63200393e11
https://hg.mozilla.org/mozilla-central/rev/e124eaad5796
https://hg.mozilla.org/mozilla-central/rev/930746805f84
https://hg.mozilla.org/mozilla-central/rev/a9278b676ed7
https://hg.mozilla.org/mozilla-central/rev/02d1bdc452ee
https://hg.mozilla.org/mozilla-central/rev/d30f0b8928a0
https://hg.mozilla.org/mozilla-central/rev/b49188db8ce9
https://hg.mozilla.org/mozilla-central/rev/6067c2f1c5ea
https://hg.mozilla.org/mozilla-central/rev/da75c3698a30
https://hg.mozilla.org/mozilla-central/rev/a68446036367
https://hg.mozilla.org/mozilla-central/rev/018c55895d48
https://hg.mozilla.org/mozilla-central/rev/2c032e405d58

Status: NEW → RESOLVED
Closed: 17 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
Regressions: 2087770

Perfherder has detected a build_metrics performance change from push 2c032e405d58954cd819179bfac6466b7f8034ed.

No action is required from the author; this comment is provided for informational purposes only.

Improvement Test Platform Options Absolute values [old vs new]
0.21% installer size osx-aarch64-nightlyasrelease nightly nightly-as-release 123,179,373.67 -> 122,923,331.33
0.15% installer size win64-nightlyasrelease nightly nightly-as-release 144,654,988.92 -> 144,442,087.83
0.12% installer size windows2012-64-shippable nightly 146,934,624.17 -> 146,756,168.58

Need Help or Information?

If you have any questions, please reach out to aesanu@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Keywords: perf-alert
QA Whiteboard: [qa-triage-done-c162/b161]
Duplicate of this bug: 2084716
Duplicate of this bug: 2084717
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: