Closed Bug 2077231 Opened 1 month ago Closed 1 month ago

browser_test_docload.js is flaky

Categories

(Core :: Disability Access APIs, defect)

defect

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: morgan, Assigned: morgan)

References

(Blocks 1 open bug)

Details

(Whiteboard: [a11y-flakytest-fix])

Attachments

(1 external file)

See report on Florian's dashboard here

This bug tracks the work needed to restore this to green, though the work might not be in our module.

Before this patch, RPMSendQuery wrapped sendQuery in a new Promise with no rejection handler. This meant when the parent did not answer before the actor was destroyed, the AbortError was unhandled and the promise never settled. In this patch, we pass reject as the second argument to then() so the rejection settles the outer promise, and wrapPromise forwards it to the page promise.

This appears (based on several treeherder pushes) to have been the cause of the flakiness of this accessibility test.

Blocks: a11ytestdev

There is an r+ patch which didn't land and no activity in this bug for 1 week.
:morgan, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(mreschenberg)
Flags: needinfo?(mreschenberg)
Whiteboard: [a11y-flakytest-fix]
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
QA Whiteboard: [qa-ver-needed-c161/b160]
QA Whiteboard: [qa-ver-needed-c161/b160] → [qa-triage-done-c160/b159]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: