Closed Bug 2077281 Opened 1 month ago Closed 1 month ago

[WPT] css/selectors/heading.html is failed on GeckoView with fission

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: m_kato, Assigned: jfkthame)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][group6])

Attachments

(1 external file)

We are going to turn on GeckoView's WPT with fission. When running ./mach wpt /css/selectors/heading.html, this is successful even if fission. But when running ./mach wpt /css/selectors/, /css/selectors/heading.html is failed.

When running ./mach wpt /css/selectors/, the order of tests is the following.

  • /css/selectors/heading-prefixed.html
  • /css/selectors/heading.html

heading-prefixed.html uses :heading selector, but this test doesn't turn on dom.headingoffset.enabled, but next test (/css/selectors/heading.html ) turns on this prefs. Due to this reason, I guess that selector cache has invalid data.

Of course, if adding prefs: [dom.headingoffset.enabled:true] in testing/web-platform/meta/css/selectors/heading-prefixed.html.ini, /css/selectors/heading.html is successful even if by ./mach wpt /css/selectors/.

Also, I think we can reproduce this on Firefox desktop by ./mach wpt --setpref dom.ipc.processCount.webIsolated=1 /css/selectors. I can reproduce this on macOS. dom.ipc.processCount.webIsolated is different of desktop and android. Desktop is 4, but android is 1.

Blocks: 2037881
No longer blocks: 2076741

The severity field is not set for this bug.
:jfkthame, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(jfkthame)

I think we should take the simple fix (workaround) here: enable the dom.headingoffset.enabled pref for the -prefixed test, which also has the happy side-effect of making its testcases start passing (they're currently annotated as failures).

Of course this doesn't address the underlying cause, that if dom.headingoffset.enabled is changed during a session, we may have stale cached matching data. But that will be a non-issue once we enable the feature by default (bug 2044348) and subsequently remove the pref altogether (bug 1997601).

Severity: -- → S3
Flags: needinfo?(jfkthame)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Pushed by jkew@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ef1bf1474299 https://hg.mozilla.org/integration/autoland/rev/e06b11e271be Set the dom.headingoffset.enabled pref for css/selectors/heading-prefixed.html. r=firefox-style-system-reviewers,emilio
Whiteboard: [fxdroid][group6]
Summary: css/selectors/heading.html is failed on GeckoView with fission → [WPT] css/selectors/heading.html is failed on GeckoView with fission
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
QA Whiteboard: [qa-ver-needed-c161/b160]
QA Whiteboard: [qa-ver-needed-c161/b160] → [qa-triage-done-c160/b159]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: