Closed Bug 2078031 Opened 1 month ago Closed 4 days ago

[wpt-sync] Sync PR 63244 - Let the stash manager allocate its own TCP port

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox162 fixed)

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 63244 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/63244
Details from upstream follow.

Domenic Denicola <d@domenic.me> wrote:

Let the stash manager allocate its own TCP port

When binding the stash to the configured server host, wpt serve first probes for an available port and closes the probe socket before starting the manager. Another listener can claim that port in between, causing the manager to fail with EADDRINUSE and abort server startup.

Pass port 0 directly to the manager instead. Its existing startup protocol returns the bound address, which StashServer already publishes to workers through WPT_STASH_CONFIG.


This is part of a series of PRs to try to fix port-allocation races that jsdom has encountered while using wpt serve. I asked GPT-6 Astra Extra High to extract them into small, reviewable fixes, but I'm still not much of an expert in this code, so please review carefully.

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

Test result changes from PR not available.

Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.