2078113 - Show "Search tabs" keyboard shortcuts in the search mode switcher menu

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Dão Gottwald [:dao]]

Bug 1666654 adds Ctrl+Shift+A (Cmd+Shift+A on macOS) for searching tabs. The search mode switcher menu should show it on its Tabs item, and show the web search shortcut (Ctrl+K / Cmd+K) on the default engine when no search bar is in the toolbar (with a search bar, that shortcut focuses the search bar instead).

panel-item has no way to display a shortcut today. This needs a shortcut attribute on panel-item, and an aria-keyshortcuts value so screen readers get the shortcut, since the visible text is kept out of the item's name.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 2078113 - Support a keyboard shortcut label on panel-item. r?#reusable-components-reviewers

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 2078113 - Set aria-keyshortcuts on items that CustomizableUI.addShortcut gives a shortcut label. r?#accessibility-frontend-reviewers

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 2078113 - Show the Search Tabs shortcut in the search mode switcher. r?#search-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0937d7ffe1fa
https://hg.mozilla.org/integration/autoland/rev/b0a088437698
Support a keyboard shortcut label on panel-item. r=reusable-components-reviewers,desktop-theme-reviewers,akulyk

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/43cbc4a304df
https://hg.mozilla.org/integration/autoland/rev/d71b5d5603a7
Show the Search Tabs shortcut in the search mode switcher. r=search-reviewers,urlbar-reviewers,daleharvey

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b0a088437698

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/76f4087a874d
https://hg.mozilla.org/integration/autoland/rev/30d0cd173e48
Revert "Bug 2078113 - Show the Search Tabs shortcut in the search mode switcher. r=search-reviewers,urlbar-reviewers,daleharvey" for causing bc failures @ browser_restrict_keywords.js

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_restrict_keywords

Backout link: https://hg.mozilla.org/integration/autoland/rev/30d0cd173e48c25436004958f576cdc1cc0e8123

Push with failures

Failure log ->TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_restrict_keywords.js | test_search_restrict_keyword_results - Expected searchMode

Comment 9

[Phabricator Automation]

Comment on attachment 9652891 [details]
Bug 2078113 - Set aria-keyshortcuts on items that CustomizableUI.addShortcut gives a shortcut label. r?#accessibility-frontend-reviewers

Revision D330671 was moved to bug 2079160. Setting attachment 9652891 [details] to obsolete.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/afcc3817b958
https://hg.mozilla.org/integration/autoland/rev/98cd018e505d
Show the Search Tabs shortcut in the search mode switcher. r=search-reviewers,urlbar-reviewers,daleharvey

Comment 11

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/98cd018e505d

Comment 12

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Verified as fixed on Firefox Nightly 159.0a1 on Windows 11, Ubuntu 22, macOS 13.

Comment 13

[Performance Sheriff Bot]

Perfherder has detected a browsertime performance change from push 98cd018e505d2952f0ee85798a029cbba82529e8.

No action is required from the author; this comment is provided for informational purposes only.

Improvement	Test	Platform	Options	Absolute values [old vs new]	Performance Profiles
1%	speedometer3 (doc)	linux2404-64-shippable	fission webrender	15.76 score -> 15.85 score	Before/After
1%	speedometer3 score (doc)	linux2404-64-shippable	fission webrender	15.76 score -> 15.85 score	Before/After

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.