2078278 - Support [Tainted] annotations on individual types (in parameters)

Status: RESOLVED FIXED

(Core :: IPC, task)

Description

[Tom Schuster [:tschuster]]

Especially for nsIPrincipal it would be useful to have a [Tainted] annotation per type instead of per method. That means any additional usage of the type will automatically require tainting. Doing this for parameters seems quite easy, so I will go for that first. We can add support for types inside structs/unions afterwards.

One thing I wasn't quite sure about is if we should make tained type move-only, I think it might be a good idea because otherwise we might get a bunch of additional Add/Release calls due to introduction of RefPtr<nsIPrincipal> instead of nsIPrincipal*.

Comment 1

[Tom Schuster [:tschuster]]

Attachment: Bug 2078278 - Support [Tainted] annotations on individual C++ types (in parameters). r?nika

Comment 2

[Tom Schuster [:tschuster]]

Attachment: Bug 2078278 - Use tainting exclusively for PContent::LoadURIExternal

Comment 3

[Tom Schuster [:tschuster]]

Attachment: Bug 2078278 - Check which actor side gets Tainted<> in IPDL ok tests. r?nika

Ok tests previously only checked that compilation succeeded, so they could
not tell whether [Tainted] types ended up tainted on the right side.

Comment 4

[Phabricator Automation]

Comment on attachment 9653500 [details]
Bug 2078278 - Use tainting exclusively for PContent::LoadURIExternal

Revision D331089 was moved to bug 2087980. Setting attachment 9653500 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/36ee783d0f3f
https://hg.mozilla.org/integration/autoland/rev/aca3c357510d
Support [Tainted] annotations on individual C++ types (in parameters). r=nika,ipc-reviewers
https://github.com/mozilla-firefox/firefox/commit/cc2456c75dee
https://hg.mozilla.org/integration/autoland/rev/cdeb0e67cb5f
Check which actor side gets Tainted<> in IPDL ok tests. r=nika,ipc-reviewers

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/aca3c357510d
https://hg.mozilla.org/mozilla-central/rev/cdeb0e67cb5f