Selenium test 4_test_votes.t fails with Firefox ESR 153 because go_to_bug doesn't wait for the module expand animation
Categories
(bugzilla.mozilla.org :: Continous Integration, defect)
Tracking
()
People
(Reporter: dkl, Assigned: dkl)
Details
Attachments
(2 files)
Since about Oct 2, test_selenium group 4 fails in CI on every PR, including unrelated ones like the dompurify bump:
Failed test '4 votes remaining' at 4_test_votes.t line 219.
Failed test '2 votes remaining' at 4_test_votes.t line 240.
The test image installs firefox-esr from Debian without a pinned version, and Debian moved from 140.16.0esr to 153.4.0esr. Code from Sep 22 that passed CI on Sep 22 fails now, so this isn't a regression in BMO itself.
The page renders the correct vote counts. The problem is timing. QA::Util::go_to_bug clicks "Expand all", which runs a 200ms jQuery
slideDown. While the slide runs, jQuery sets overflow:hidden and a growing height on .module-content. The votes field is still clipped, so WebDriver
treats it as not displayed and get_text returns ''. Firefox 153 runs the WebDriver commands fast enough to read the field before the slide finishes.
Fix: after clicking expand-all, go_to_bug polls jQuery(":animated") until the animation ends, with a 5 second cap.
|
||
Comment 1•1 day ago
|
||
(via GitHub webhook, authenticated as shared-secret)
|
|
||
Comment 2•5 hours ago
|
||
Authored by https://github.com/dklawren
https://github.com/mozilla/bmo/commit/0dec536d73c7c3ae8afe128b92883a8f717f771c
[master] Bug 2078352 - Selenium test 4_test_votes.t fails with Firefox ESR 153 because go_to_bug doesn't wait for the module expand animation (#2769)
(via GitHub webhook, authenticated as shared-secret)
|
|
||
Comment 3•5 hours ago
|
||
Authored by https://github.com/dklawren
https://github.com/mozilla/bmo/commit/edcb186b0f8d61363ca20acd2c1f15974886eaa8
[master] Revert "Bug 2078352 - Selenium test 4_test_votes.t fails with Firefox ESR 153 because go_to_bug doesn't wait for the module expand animation (#2769)"
(via GitHub webhook, authenticated as shared-secret)
|
|
||
Comment 4•5 hours ago
|
||
(via GitHub webhook, authenticated as shared-secret)
|
|
||
Comment 5•5 hours ago
|
||
Authored by https://github.com/dklawren
https://github.com/mozilla/bmo/commit/8de0b60239d201277824f17067935f67f2363507
[master] Bug 2078352 - Selenium test 4_test_votes.t fails with Firefox ESR 153 because go_to_bug doesn't wait for the module expand animation
(via GitHub webhook, authenticated as shared-secret)
Description
•