2078366 - AttributeError fetching revision with Jujutsu

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[Andrew Halberstadt [:ahal]]

I hit an exception while running:

moz-phab patch D327415 --apply-to base --yes --name phab-D327415

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2078366 - share parsed args with the wrapped Git repo in set_args, r?sheehan!,shtrom!

The wrapped Git repo reads args beyond what get_diff needs, e.g. upstream
when picking remotes in is_public and get_latest_landing_node. Until now
the args were only assigned to it inside get_diff, so calls made before
that (such as public-ancestor checks while validating the stack in submit)
ran without args and could fail or ignore --upstream.

Assign the args in set_args so the Git repo has them from the start, and
add a test covering it.

Comment 2

[BMO Github Automation]

Authored by https://github.com/ahal
https://github.com/mozilla-conduit/review/commit/45b85378c33b612a01164280d2e324283ae23cd9
[main] Bug 2078366 - share parsed args with the wrapped Git repo in set_args, r=sheehan

(via GitHub webhook, authenticated as shared-secret)