Intern rectangles in the display list builder
Categories
(Core :: Graphics: WebRender, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox160 | --- | fixed |
People
(Reporter: gw, Assigned: gw)
References
Details
(Keywords: perf-alert)
Attachments
(1 external file)
| Assignee | ||
Comment 1•1 month ago
|
||
The first interned type, plus the machinery every primitive type shares.
Primitive keys hold the prim rect, local clip rect and flags, so an item is
only its spatial id, clip chain and handle, and the scene builder places the
instance from a PrimPlacement store (add_dl_prim). The two ids stay on the
item because content numbers them per build.
Since an item no longer carries what its shadow copy needs, primitives pushed
in a shadow scope record a CapturedKey that the desugar interns copies from.
A handle-less rectangle in a finished list is a transparent checkerboard,
kept only for its tile cache barrier.
A fresh builder re-mints every uid, so an identical list from a new builder
repaints; test_invalidation covers it. wrshell's capture writer now emits
placeholder bounds and colour.
Updated•1 month ago
|
Backed out for causing mda crashes
| Assignee | ||
Comment 6•1 month ago
|
||
Fixed up the namespace lifetime issue causing that.
Comment 9•1 month ago
|
||
Backed out for causing failures at browser_window_open_modifiers.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/cdb74ad03c32
Failure log: https://treeherder.mozilla.org/logviewer?job_id=599939553&repo=autoland&task=KdVmKqZKRLa1StfXzRn3kw.0&lineNumber=6236
| Assignee | ||
Updated•1 month ago
|
Comment 10•28 days ago
|
||
Comment 11•28 days ago
|
||
| bugherder | ||
Comment 12•21 days ago
|
||
Perfherder has detected a talos performance change from push 2a53f18f1858af74baea0b5e6edf9fd5b8bbab40.
No action is required from the author; this comment is provided for informational purposes only.
| Improvement | Test | Platform | Options | Absolute values [old vs new] |
|---|---|---|---|---|
| 8% | displaylist_mutate (doc) | macosx1500-aarch64-shippable | e10s fission stylo webrender | 595.05 -> 546.74 |
Need Help or Information?
If you have any questions, please reach out to bacasandrei@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
Updated•19 days ago
|
Description
•