Closed Bug 2078462 Opened 1 month ago Closed 28 days ago

Intern rectangles in the display list builder

Categories

(Core :: Graphics: WebRender, task)

task

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: gw, Assigned: gw)

References

Details

(Keywords: perf-alert)

Attachments

(1 external file)

No description provided.

The first interned type, plus the machinery every primitive type shares.
Primitive keys hold the prim rect, local clip rect and flags, so an item is
only its spatial id, clip chain and handle, and the scene builder places the
instance from a PrimPlacement store (add_dl_prim). The two ids stay on the
item because content numbers them per build.

Since an item no longer carries what its shadow copy needs, primitives pushed
in a shadow scope record a CapturedKey that the desugar interns copies from.
A handle-less rectangle in a finished list is a transparent checkerboard,
kept only for its tile cache barrier.

A fresh builder re-mints every uid, so an identical list from a new builder
repaints; test_invalidation covers it. wrshell's capture writer now emits
placeholder bounds and colour.

Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Pushed by amarc@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/468f1edeaa34 https://hg.mozilla.org/integration/autoland/rev/fd966ad73701 Revert "Bug 2078462 - Intern rectangles in the display list builder r=gfx-reviewers,nical" for causing mda crashes at mozglue_static

Backed out for causing mda crashes

Flags: needinfo?(mozilla)

Fixed up the namespace lifetime issue causing that.

Flags: needinfo?(mozilla)
Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d9996dda0c58 https://hg.mozilla.org/integration/autoland/rev/cdb74ad03c32 Revert "Bug 2078462 - Intern rectangles in the display list builder r=gfx-reviewers,nical" for causing failures at browser_window_open_modifiers.js.
Flags: needinfo?(mozilla)
Blocks: 2078306
Status: ASSIGNED → RESOLVED
Closed: 28 days ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
Regressions: 2084501

Perfherder has detected a talos performance change from push 2a53f18f1858af74baea0b5e6edf9fd5b8bbab40.

No action is required from the author; this comment is provided for informational purposes only.

Improvement Test Platform Options Absolute values [old vs new]
8% displaylist_mutate (doc) macosx1500-aarch64-shippable e10s fission stylo webrender 595.05 -> 546.74

Need Help or Information?

If you have any questions, please reach out to bacasandrei@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Keywords: perf-alert
QA Whiteboard: [qa-triage-done-c161/b160]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: