Closed
Bug 2078543
Opened 1 month ago
Closed 1 month ago
DoShiftReloadConnectionCleanupWithConnInfo should not cancel all connections
Categories
(Core :: Networking: HTTP, defect, P1)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
160 Branch
| Tracking | Status | |
|---|---|---|
| firefox160 | --- | fixed |
People
(Reporter: valentin, Assigned: valentin)
References
Details
(Whiteboard: [necko-triaged][necko-priority-next])
Attachments
(1 external file)
It seems the DoShiftReloadConnectionCleanupWithConnInfo call nsHttpChannel::BeginConnect is actually closing all connections:
mCoalescingHash.Clear();
nsHttpConnectionInfo* ci = static_cast<nsHttpConnectionInfo*>(param);
bool preserveTRR = StaticPrefs::network_trr_preserve_on_background();
for (const auto& entry : mCT.Values()) {
if (preserveTRR && entry->mConnInfo->GetIsTrrServiceChannel()) {
continue;
}
entry->ClosePersistentConnections();
}
This is not correct. It should only close those matching the connection info origin attributes.
| Assignee | ||
Comment 1•1 month ago
|
||
Pushed by valentin.gosu@gmail.com:
https://github.com/mozilla-firefox/firefox/commit/69fbc6656b57
https://hg.mozilla.org/integration/autoland/rev/8d1c6358c8fd
DoShiftReloadConnectionCleanupWithConnInfo should not cancel all connections r=necko-reviewers,kershaw
Comment 3•1 month ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox160:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
Updated•23 days ago
|
QA Whiteboard: [qa-triage-done-c161/b160]
You need to log in
before you can comment on or make changes to this bug.
Description
•