2078827 - Uplift revisions are created as WIP when the original revision has no reviewers (`moz-phab` pinned to 2.9.0)

Status: RESOLVED FIXED

(Conduit :: Lando, defect, P3)

Description

[Connor Sheehan [:sheehan]]

Lando uplift automation created https://phabricator.services.mozilla.com/D331253 as a WIP uplift revision.

The original revision we are uplifting is https://phabricator.services.mozilla.com/D323163, which has no reviewers. moz-phab submit treats "no reviewers" as "this must be a wip". moz-phab uplift is just a wrapper around moz-phab submit, and even though it removes the reviewers so automation can add #release-managers! later, it parses the commit message and sees no reviewers, marking the revision as WIP.

moz-phab uplift should avoid the "no reviewers -> wip" semantics and only mark a revision as WIP if explicitly called out via flags or WIP: in the commit title.

Comment 1

[Mathew Hodson]

The code in update_commits_from_args already checks for args.command != "uplift" and doesn't set WIP in that case.

Could lando be running moz-phab submit or some other command first before the uplift? If that's the case, those previous commands could be amending the commit title to "WIP: blahblah" in lando's local repo. And then that amended commit is used for the uplift command.

Comment 2

[Connor Sheehan [:sheehan]]

(In reply to Mathew Hodson from comment #1)

The code in update_commits_from_args already checks for args.command != "uplift" and doesn't set WIP in that case.

Could lando be running moz-phab submit or some other command first before the uplift? If that's the case, those previous commands could be amending the commit title to "WIP: blahblah" in lando's local repo. And then that amended commit is used for the uplift command.

You're right, we did fix this already. Lando is running version 2.9.0, we resolved this issue in 2.9.1. :)

So the real fix is to update Lando to use the latest moz-phab.

Comment 3

[BMO Github Automation]

Attachment: [mozilla-conduit/lando] uplift: update moz-phab to pick up the uplift WIP fix (bug 2078827) (#1534)

(via GitHub webhook, authenticated as shared-secret)

Comment 4

[BMO Github Automation]

Authored by https://github.com/cgsheeh
https://github.com/mozilla-conduit/lando/commit/e6c8c06b7a7987b97b2347aba95ebc1e42eee599
[main] uplift: update moz-phab to pick up the uplift WIP fix (bug 2078827) r=zeid

(via GitHub webhook, authenticated as shared-secret)