Closed Bug 2079413 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 63345 - [chromium-bidi] Fix element clip screenshot in scrolled viewport

Categories

(Remote Protocol :: WebDriver BiDi, task, P4)

task

Tracking

(firefox160 fixed)

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 63345 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/63345
Details from upstream follow.

Maksim Sadym <sadym@chromium.org> wrote:

[chromium-bidi] Fix element clip screenshot in scrolled viewport

  • Fix browsingContext.captureScreenshot with an element clip when the
    page is scrolled, and add WPT test_clip_element_scroll_to.
  • Previously, #parseRect returned viewport-relative coordinates from
    getBoundingClientRect() without adding the visual viewport scroll
    offset, causing incorrect clipping or zero-dimension intersection
    errors after scrolling.
  • Add visualViewport.pageLeft and visualViewport.pageTop to the element
    bounding box to convert it to document coordinates per the WebDriver
    BiDi specification.

Bug: 418765619
Cq-Include-Trybots: luci.chromium.try:linux-webdriver-bidi-rel
Include-Ci-Only-Tests: chromium.linux:Linux Tests|webdriver_wpt_tests
Change-Id: Ia0c25a27d0b36e30ede590d270c54f3e4ad4fe8e
Reviewed-on: https://chromium-review.googlesource.com/8520000
WPT-Export-Revision: 73018056f7ce294cd79f16c8a14c329853629462

Component: web-platform-tests → WebDriver BiDi
Product: Testing → Remote Protocol

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 7 tests and 4 subtests

Status Summary

Firefox

OK : 1[GitHub] 7[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 11[GitHub] 119[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 127[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 1
PASS : 10
FAIL : 1

Safari

OK : 1
ERROR: 11

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/072fa29099a1 https://hg.mozilla.org/integration/autoland/rev/68ec00744c4a [wpt PR 63345] - [chromium-bidi] Fix element clip screenshot in scrolled viewport, a=testonly
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
You need to log in before you can comment on or make changes to this bug.