Closed Bug 2079414 Opened 1 month ago Closed 20 days ago

Move the code from the createStartupConfig method to home-startup.mjs from main.js

Categories

(Firefox :: Settings UI, task)

task

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: hjones, Assigned: hjones)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [recomp])

Attachments

(1 external file)

We have a createStartupConfig method in main.js that was created for/used to be necessary when we had to worry about rendering that section on different panes depending on the state of the SRD pref. Once that pref is removed we no longer have to worry about ever rendering this section on the general pane, and can move all the related logic to home-startup.mjs.

We don't necessarily have to keep the method, but we should move all the associated config and settings registration. We can remove this call to render that section on the general pane.

Assignee: nobody → hjones
Status: NEW → ASSIGNED
Blocks: 2079961
Pushed by hjones@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/61cc0452f371 https://hg.mozilla.org/integration/autoland/rev/375cc130f784 move code from from the createStartupConfig method to home-startup.mjs from main.js r=settings-reviewers,mconley
Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/4cdac103dab7 https://hg.mozilla.org/integration/autoland/rev/fc7a16489ab5 Revert "Bug 2079414 - move code from from the createStartupConfig method to home-startup.mjs from main.js r=settings-reviewers,mconley" for causing bc failures @ browser_sessionRestoreNewTab.js
Pushed by hjones@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e4cb0f7de19c https://hg.mozilla.org/integration/autoland/rev/b272f3c38d37 move code from from the createStartupConfig method to home-startup.mjs from main.js r=settings-reviewers,mconley
Pushed by ctuns@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/03c426c3dbc3 https://hg.mozilla.org/integration/autoland/rev/ede946f8423a Revert "Bug 2079414 - move code from from the createStartupConfig method to home-startup.mjs from main.js r=settings-reviewers,mconley" for causing bc failures with startup-windows-launch-on-login-profile-disabled

Backed out for causing mochitest failures

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/applications/browser_applications_search_results.js | testApplicationsLoadInSearchResults - uncaught rejection: [fluent] Missing message in locale en-US: startup-windows-launch-on-login-profile-disabled
Pushed by hjones@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5edd55931c92 https://hg.mozilla.org/integration/autoland/rev/12f601a9b022 move code from from the createStartupConfig method to home-startup.mjs from main.js r=settings-reviewers,mconley
Status: ASSIGNED → RESOLVED
Closed: 20 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
Flags: needinfo?(hjones)
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: