Draw the content behind a backdrop-filter into its capture instead of resolving it from the backdrop root
Categories
(Core :: Graphics: WebRender, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox160 | --- | fixed |
People
(Reporter: gw, Assigned: gw)
References
(Blocks 1 open bug)
Details
Attachments
(5 external files, 2 obsolete files)
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Comment 1•1 month ago
|
||
Each frame, record every reachable backdrop-filter chain's backdrop root,
capture primitive, and the area of the root surface its filters read. Nothing
uses this yet beyond HIGHLIGHT_BACKDROP_FILTERS and a profiler counter.
| Assignee | ||
Comment 2•1 month ago
|
||
Copying the backdrop root's pixels required splitting its tasks around every
backdrop-filter. Instead, each primitive behind a filter emits its commands
into the capture's command buffer as well as the root's, so it is still
prepared once, and the capture depends on the same render tasks. The resolve
is now unreachable and is removed in the following patches.
The capture task is cleared and scissored to its content area, since a blur
samples its padding. The deferred dirty test covers the whole capture region,
which a drop shadow can sample beyond the element.
Updated•1 month ago
|
Updated•1 month ago
|
Updated•1 month ago
|
Updated•1 month ago
|
| Assignee | ||
Comment 3•1 month ago
|
||
Each frame, record every reachable backdrop-filter chain's backdrop root,
capture primitive, and the area of the root surface its filters read. Nothing
uses this yet beyond HIGHLIGHT_BACKDROP_FILTERS.
| Assignee | ||
Comment 4•1 month ago
|
||
Copying the backdrop root's pixels required splitting its tasks around every
backdrop-filter. Instead, the capture is open on the backdrop root's surface
from when the root is prepared until the capture's picture is, as one more
target: each primitive behind the element emits its commands into it as well
as the root's, so it is still prepared once, and the capture depends on the
same render tasks. The resolve is now unreachable and is removed in the
following patches.
The capture task is cleared and scissored to its content area, since a blur
samples its padding. The deferred dirty test covers the whole capture region,
which a drop shadow can sample beyond the element.
| Assignee | ||
Comment 5•1 month ago
|
||
Nothing registers a resolve source any more, so the backdrop root's tasks are
never split.
| Assignee | ||
Comment 6•1 month ago
|
||
Tiles under a backdrop-filter rendered into an enlarged task, copied into the
tile, so that the task could be split for the resolve. Nothing splits tile
tasks any more.
| Assignee | ||
Comment 7•1 month ago
|
||
A capture needed a render target of its own for the resolve to copy into. It
now clears and scissors its own task, so it can share one, and a chain's
surface is popped like any other.
Comment 9•1 month ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ea745deba60c
https://hg.mozilla.org/mozilla-central/rev/fb3b55d32e19
https://hg.mozilla.org/mozilla-central/rev/081c24ee1f83
https://hg.mozilla.org/mozilla-central/rev/17b22abfced1
https://hg.mozilla.org/mozilla-central/rev/59fe71d7c538
Updated•21 days ago
|
Description
•