2079498 - Show the security code checkbox in the card doorhanger when security codes are supported, and offer device sign-in after Save

Status: REOPENED

(Toolkit :: Form Autofill, task)

Description

[Micah [:mtigley] (she/her)]

1. Security code checkbox visibility and state
2. Save continues to the device sign-in step.

Tests: browser/extensions/formautofill/test/browser/creditCard/browser_creditCard_doorhanger_cvv.js. Cover the three checkbox states, Save opening the device sign-in step only when OS auth is off and no primary password is set, and Dismiss never opening it.

Comment 1

[Micah [:mtigley] (she/her)]

Attachment: Bug 2079498 - Offer the security code checkbox in the card doorhanger whenever security codes are supported. r?#credential-management-reviewers

The checkbox now follows extensions.formautofill.creditCards.cvv.supported
rather than requiring capture to already be on, and starts from the
"Save security codes" setting, so a user who turned it off can turn it back
on from the doorhanger.

Depends on D333474

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/96eb774681eb
https://hg.mozilla.org/integration/autoland/rev/407e2ef47d69
Offer the security code checkbox in the card doorhanger whenever security codes are supported. r=credential-management-reviewers,dimi

Comment 3

[rperta]

https://hg.mozilla.org/mozilla-central/rev/407e2ef47d69

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9046137a91a4
https://hg.mozilla.org/integration/autoland/rev/d546d4277bd0
Revert "Bug 2079498 - Offer the security code checkbox in the card doorhanger whenever security codes are supported. r=credential-management-reviewers,dimi" for causing bc failures @browser_creditCard_capture_cvv.js.

Comment 5

[agoloman]

Backed out for causing bc failures @browser_creditCard_capture_cvv.js.

• Backout link
• Push with failures
• Failure Log