Closed
Bug 2079606
Opened 1 month ago
Closed 29 days ago
Copy Link to Highlight, Copy Clean Link to Highlight, Remove Highlight, Add Comment to Selection and Highlight Selection in the content context menu have no accesskey
Categories
(Firefox :: Menus, task)
Firefox
Menus
Tracking
()
RESOLVED
FIXED
160 Branch
| Tracking | Status | |
|---|---|---|
| firefox160 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
These items (text-action-*-highlight in textActions.ftl and the comment and highlight selection items) have no accesskey beside items that do. Bug 2073889 fixed the navigation items. Found by the accesskey check (bug 2073853), which this menu opts out of with accesskey-conflicts-bug until the conflicts are fixed. Conflicts are per visible menu instance, so a letter has to be free among the items that can show together. A message whose accesskey changes gets a new Fluent id; no migration recipe. Remove the menu's opt-out attribute once no 9a bug is left.
| Assignee | ||
Comment 1•1 month ago
|
||
Remove Highlight shares H with Copy Link to Highlight, since it only shows on a page opened with a text fragment and no other letter of its label is free.
Updated•1 month ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/c98364c8f2b9
https://hg.mozilla.org/integration/autoland/rev/6e92c23083df
Give the highlight items and the PDF viewer's comment and highlight items in the content context menu accesskeys. r=firefox-desktop-core-reviewers ,fluent-reviewers,Gijs,bolsson
Comment 3•29 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 29 days ago
status-firefox160:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
Updated•21 days ago
|
QA Whiteboard: [qa-triage-done-c161/b160]
You need to log in
before you can comment on or make changes to this bug.
Description
•