2079661 - Allow passive content for ContentClassifier fingerprinter feature

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P2)

Description

[Tim Huang[:timhuang]]

The URLClassifier skips passive content for fingerprinter blocking and annotation. The ContentClassifier "fingerprinters" feature has no equivalent check.

To align the behavior, we need to implement skipping passive content for the fingerprinter feature.

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 2079661 - Skip passive content in the ContentClassifier fingerprinters engine to match url-classifier. r?emz!

This patch changes the fingerprinters engine to skip image and media loads
in both the cancel and the annotate pass. url-classifier's fingerprinting
features return early for passive content, so the content classifier was
blocking and annotating loads that url-classifier never touched. The request
records passiveness through ChannelClassifierUtils::IsPassiveContent rather
than its type string, which also maps imageset loads to "image".

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e59c9f94f5ef
https://hg.mozilla.org/integration/autoland/rev/e208bdac3151
Skip passive content in the ContentClassifier fingerprinters engine to match url-classifier. r=emz

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e208bdac3151