2079733 - layout.css.always_underline_links overrides existing text-decoration

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P3)

Description

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Any existing non-underline properties like text-decoration: line-through is overridden by the pref, which can negatively affect site usability e.g. in Bugzilla.

Not sure this is easily fixable, as fixing it in normal CSS would require a separate div that adds the property.

Comment 1

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Perhaps !important can go away to mitigate the issue?

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Yeah this is sorta working-as-expected. Removing !important would totally break the feature.

The only reasonable fix I can think of would be moving the feature to C++ or Rust. Probably the easiest way would be something like StyleAdjuster::adjust_for_link_underlines or so?

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2079733 - Move always_underline_links to StyleAdjuster. r=#style

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/eab940c23bd1
https://hg.mozilla.org/integration/autoland/rev/456b237d69b1
Move always_underline_links to StyleAdjuster. r=layout-reviewers,jfkthame

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/52d552093da4
https://hg.mozilla.org/integration/autoland/rev/9f8cbc5276e0
Revert "Bug 2079733 - Move always_underline_links to StyleAdjuster. r=layout-reviewers,jfkthame" for causing failures complaining about testAlwaysUnderlineLinks.

Comment 6

[Atila Butkovits]

Backed out for causing failures complaining about testAlwaysUnderlineLinks.

Backout link: https://hg.mozilla.org/integration/autoland/rev/9f8cbc5276e0

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2C24.04%2Copt%2Cmochitests%2Ctest-linux2404-64%2Fopt-mochitest-browser-a11y%2Cba&revision=456b237d69b1b126080079e6b7aa51fb50cfbc00

Failure log: https://treeherder.mozilla.org/logviewer?job_id=598800776&repo=autoland&task=Z5ry87o3TzW4Mybcil1z6g.0&lineNumber=8340

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/eaa37f33de43
https://hg.mozilla.org/integration/autoland/rev/63aacff3dc73
Move always_underline_links to StyleAdjuster. r=layout-reviewers,jfkthame

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/63aacff3dc73