2079831 - [Nova] borders misalign in compact mode for zoom select in pdf.js

Status: RESOLVED DUPLICATE of bug 2075731

(Firefox :: PDF Viewer, defect)

Description

[Manuel Bucher [:manuel]]

Attach (recommended) or Link to PDF file here:

Steps to reproduce the problem:

1. Enable compact mode (settings -> search for compact)
2. Open a PDF (e.g. https://raw.githubusercontent.com/mozilla/pdf.js/89b500f5e1d98ed89bb90211e45b28730b2d99ac/web/compressed.tracemonkey-pldi-09.pdf)

What is the expected behavior? borders don't get hidden, probably by using smaller border radius. Other border radius get adjusted (e.g. search bar)

What went wrong? See screenshot: Upper border not visible, bottom border too close to the toolbar bottom.

Mozregression points to https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=67e4133f8dfa6826e96ff048371a268952c086d8&tochange=a06d3d539e9102863a6b4e3b2ff7df65ab89da20, likely bug 2063815. And from that likely bug 2063405.

Comment 1

[BugBot [:suhaib / :marco]]

:calixte, since you are the author of the regressor, bug 2063405, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Hackbot [:hackbot]]

Possible duplicate: 2075731

In compact density, the Nova rules in viewer.css lower --toolbar-height to 32px but keep the 4px vertical padding and 1px bottom border. That leaves a 23px content box. The Nova .dropdownToolbarButton block at #8359-8380 still gives the select min-height: var(--button-min-height), which is 32px per tokens-shared.css. With the 1px container border the dropdown is 34px tall, and centering pushes it 1.5px past the top of the toolbar and over its bottom border. .toolbarButton uses height: 100% and shrinks with the toolbar, but the dropdown does not.

Fix: This file is vendored, so the fix belongs upstream in mozilla/pdf.js web/viewer.css and arrives with the next update. Under [data-toolbar-density="compact"], make the Nova dropdown fit the toolbar: drop the fixed min-height (or bound it to the toolbar's content height), use the small padding-block token, and use the smaller border radius suggested in comment 0. Changing the toolbar padding alone does not help, because a centered 34px control overflows the same amount regardless.

Suggested severity: S4. This is a cosmetic border clip that only users who pick compact density see, and the zoom control still works.

---

If you'd like to provide feedback on this comment, please use the 👍 or 👎 reaction.
If you want to categorize your feedback you can add one of the following tags: ai-triage-{wrong-file, wrong-cause, hallucination, out-of-scope, not-a-bug, wrong-fix, shallow-fix, wrong-severity}.

Needinfo [e-mail] to have a patch generated for this bug, include any questions or directions as needed in your comment.

Comment 3

[Manuel Bucher [:manuel]]

Yes, haven't found that one. Actually a duplicate 🙈️