2079834 - Drop scopes in oauth url when sync decoupling is enabled

Status: RESOLVED FIXED

(Firefox for Android :: Accounts and Sync, task)

Description

[Segun Famisa [:segun]]

As part of bug 2066516 , in order to support authentication in a decoupled state, we need to drop scopes parameter when sync decoupling is enabled.

Bug 2074136 will ensure that the authentication URL is built correctly when we send an empty list of scopes.

Implementation ideas:

In FxaAccountManager.beginAuthentication, we could inject the logic that checks if SyncConfig.syncDecouplingEnabled is true, and then ensures that an empty list of scopes is passed to the BeginAuthFlow & BeginPairingFlow

Comment 1

[BMO Github Automation]

Attachment: [mozilla-firefox/firefox] Bug 2079834 - Don't send scopes to fxa-client when sync decoupling is enabled (#385)

(via GitHub webhook, authenticated as shared-secret)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ff16f9139b1f
https://hg.mozilla.org/integration/autoland/rev/b6f22ac8997d
Don't send scopes to fxa-client  when sync decoupling is enabled r=titouan,twhite

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b6f22ac8997d