Closed Bug 2079894 Opened 1 month ago Closed 20 days ago

Move the code from the createDefaultBrowserConfig method out of main.js

Categories

(Firefox :: Settings UI, task)

task

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: hjones, Assigned: hjones)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [recomp])

Attachments

(1 external file)

As part of the work to unwind the "General" pane from legacy settings it would be nice to come up with a better solution for the createDefaultBrowserConfig which is used to generate the default browser UI in both the new "Account and sync" and "Home" panes. As a first step we can at least move this logic out of main.js so that it'll make that file easier to clean up.

Assignee: nobody → hjones
Status: NEW → ASSIGNED
Blocks: 2079961
Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1928c80b890d https://hg.mozilla.org/integration/autoland/rev/c04b99e87813 Revert "Bug 2079894 - move createDefaultBrowserConfig out of main.js r=settings-reviewers,mconley" for causing bc failures @ browser_sessionRestoreNewTab.js
Pushed by ctuns@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b7c19c9e7f43 https://hg.mozilla.org/integration/autoland/rev/dd9235651d3c Revert "Bug 2079894 - move createDefaultBrowserConfig out of main.js r=settings-reviewers,mconley" for causing bc failures with startup-windows-launch-on-login-profile-disabled

Backed out for causing mochitest failures

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/applications/browser_applications_search_results.js | testApplicationsLoadInSearchResults - uncaught rejection: [fluent] Missing message in locale en-US: startup-windows-launch-on-login-profile-disabled
Status: ASSIGNED → RESOLVED
Closed: 20 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch

Authored by https://github.com/hannajones
https://github.com/mozilla/enterprise-firefox/commit/64addbb5da4aaa92eff676e885a15c8d625c0816
[enterprise-main] Bug 2079894 - move createDefaultBrowserConfig out of main.js r=settings-reviewers,mconley

Authored by https://github.com/c-tuns
https://github.com/mozilla/enterprise-firefox/commit/b7c19c9e7f43e94e052fdf1c546adb69a099afdf
[enterprise-main] Revert "Bug 2079894 - move createDefaultBrowserConfig out of main.js r=settings-reviewers,mconley" for causing bc failures with startup-windows-launch-on-login-profile-disabled

(via GitHub webhook, authenticated as shared-secret)

Flags: needinfo?(hjones)
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: