2079977 - [LNA] Enable LNA for Fenix by default

Status: RESOLVED FIXED

(Firefox for Android :: Browser Engine, task, P1)

Description

[Sunil Mayya]

We have rolled out LNA for Android users via Nimbus.
The plan is to enable this by default.

Comment 1

[Sunil Mayya]

Attachment: Bug 2079977 - Enable Local Network Access by default in Fenix. r?#android-reviewers

LNA has been rolled out to Android users via Nimbus. Default the lna-blocking
feature's enabled and blocking variables to true so it no longer depends
on the rollout. The Nimbus feature can still turn it off.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5b234a022d1a
https://hg.mozilla.org/integration/autoland/rev/4e4d25feede5
Enable Local Network Access by default in Fenix. r=android-reviewers,sfamisa

Comment 3

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/4e4d25feede5

Comment 4

[Sunil Mayya]

[Tracking Requested - why for this release]:
We would like to uplift this as LNA is already enabled to our release users of Android via fenix. Enablish this would mean faster shipping of this protection via default.

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: We would like to uplift this as LNA is already enabled to our release users of Android via fenix. Enablish this would mean faster shipping of this protection via default.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: This is just a pref flip, which is already enabled by Nimbus
• String changes made/needed?: No
• Is Android affected?: yes

Comment 6

[Sunil Mayya]

Attachment: Bug 2079977 - Enable Local Network Access by default in Fenix.

LNA has been rolled out to Android users via Nimbus. Default the lna-blocking
feature's enabled and blocking variables to true so it no longer depends
on the rollout. The Nimbus feature can still turn it off.

Original Revision: https://phabricator.services.mozilla.com/D332278

Comment 7

[Sunil Mayya]

Attachment: Bug 2079977 - Enable Local Network Access by default in Fenix.

LNA has been rolled out to Android users via Nimbus. Default the lna-blocking
feature's enabled and blocking variables to true so it no longer depends
on the rollout. The Nimbus feature can still turn it off.

Original Revision: https://phabricator.services.mozilla.com/D332278

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: We would like to uplift this as LNA is already enabled to our release users of Android via fenix. Enablish this would mean faster shipping of this protection via default.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: This is just a pref flip, which is already enabled by Nimbus
• String changes made/needed?: No
• Is Android affected?: yes

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Can you please point me to the Nimbus rollout for this in Experimenter?

Comment 10

[Sunil Mayya]

https://experimenter.services.mozilla.com/nimbus/rollouts/local-network-access-android-release-rollout-155/

Comment 11

[Ryan VanderMeulen [:RyanVM]]

With Metronome, the intent is that the Beta period is meant to be used for stabilization, not feature enablement. I don't see a pressing need to uplift this to Beta given that vs. letting it ride the 160 release that it landed on.

Comment 12

[Sunil Mayya]

Release Note Request (optional, but appreciated)
[Why is this notable]: We are enabling LNA restrictions by default for the first time on Android.
[Affects Firefox for Android]:
[Suggested wording]: Local Network Access restrictions are now enabled by default in Firefox for Android. Firefox now requires websites to request your permission before connecting to devices on your local network or to apps and services on your device

Comment 13

[Donal Meehan [:dmeehan]]

Added to the Fx160 nightly release notes, please allow 30 minutes for the site to update.