Closed Bug 2080140 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 63439 - [WebCodecs] Fix fractional display size scaling on visibleRect override

Categories

(Core :: Audio/Video: Web Codecs, task, P4)

task

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(2 files)

Sync web-platform-tests PR 63439 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/63439
Details from upstream follow.

Dale Curtis <dalecurtis@chromium.org> wrote:

[WebCodecs] Fix fractional display size scaling on visibleRect override

Cast default_display_size.width() and default_display_size.height() to
double before dividing by default_visible_rect dimensions in
ParsedVideoFrameInit(). Previously, integer division truncated
non-integer display-to-visible ratios to integers, producing incorrect
display dimensions for fractional scales > 1 and throwing spurious
TypeErrors when scales \< 1 truncated to zero.

Fixed: 562847603
Change-Id: I63cabd61bdc1a38d3599114288e59d0c82431694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8540370
Reviewed-by: Eugene Zemtsov \<eugene@chromium.org>
Commit-Queue: Dale Curtis \<dalecurtis@chromium.org>
Commit-Queue: Eugene Zemtsov \<eugene@chromium.org>
Auto-Submit: Dale Curtis \<dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1715044}

Component: web-platform-tests → Audio/Video: Web Codecs
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Attached file Notable wpt changes —

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 258 tests and 6 subtests

Status Summary

Firefox

OK : 2[GitHub] 175[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 239[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 241[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 72[GitHub] 1633[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 2255[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 2349[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL : 32[GitHub] 349[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 360[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PRECONDITION_FAILED: 23[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 121[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 517[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
ERROR : 4[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 12[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
NOTRUN : 40

Chrome

OK : 2
PASS : 96
FAIL : 8

Safari

OK : 2
PASS : 70
FAIL : 34

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

(See attachment for full changes)

Attached file Notable wpt changes —

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 258 tests and 6 subtests

Status Summary

Firefox

OK : 2[GitHub] 175[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 239[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 241[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 72[GitHub] 1633[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 2255[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 2349[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL : 32[GitHub] 349[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 360[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PRECONDITION_FAILED: 23[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 121[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 517[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
ERROR : 4[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 12[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
NOTRUN : 40

Chrome

OK : 2
PASS : 96
FAIL : 8

Safari

OK : 2
PASS : 70
FAIL : 34

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

(See attachment for full changes)

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/289eaffb3203 https://hg.mozilla.org/integration/autoland/rev/7294efaea66e [wpt PR 63439] - [WebCodecs] Fix fractional display size scaling on visibleRect override, a=testonly
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: