Closed Bug 2080172 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 63422 - Fix flake in select-4-option-optgroup-display-none.html

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 63422 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/63422
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

Fix flake in select-4-option-optgroup-display-none.html

Set will-change: transform on :root in
select-4-option-optgroup-display-none.html and its reference file to
prevent subpixel rendering differences on the rounded corners of the
\<select size=4> elements, and remove the failure expectation.

The flake was reproduced using UTR against 'Linux Tests (dbg)(1)'
(headless_shell_wpt_tests with --repeat-each=10), where 1 out of 10 runs
failed with a 1-channel-value difference on the rounded corner pixels.
After adding will-change: transform, all 20 runs with --repeat-each=20
on 'Linux Tests (dbg)(1)' passed without any failures.

Fixed: 567713221
Change-Id: I51b8519f4343aa997cc933a39aa748faf23d436b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8503877
Reviewed-by: Joey Arhar \<jarhar@chromium.org>
Commit-Queue: Joey Arhar \<jarhar@chromium.org>
Reviewed-by: Mason Freed \<masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1714719}

Component: web-platform-tests → Layout
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 250 tests

Status Summary

Firefox

OK : 34
PASS: 1[GitHub] 3[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 470[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 604[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 605[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 94[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 172[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 173[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/0a7aedc4f9f6 https://hg.mozilla.org/integration/autoland/rev/7eac7f8619e4 [wpt PR 63422] - Fix flake in select-4-option-optgroup-display-none.html, a=testonly
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
You need to log in before you can comment on or make changes to this bug.