Closed
Bug 2080173
Opened 1 month ago
Closed 1 month ago
WMF CDM origins list logging ignores the logging.EME pref
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
160 Branch
| Tracking | Status | |
|---|---|---|
| firefox160 | --- | fixed |
People
(Reporter: dcarver, Assigned: dcarver)
References
Details
Attachments
(1 external file)
WindowsMediaFoundationCDMOriginsListService.sys.mjs only logs when the MOZ_LOG environment variable contains EME, by checking Services.env in its log() helper.
Its console is already created with the EME prefix, which routes it through the EME log module. The extra environment check is therefore redundant, and it prevents enabling the logging at runtime through the logging.EME pref or about:logging.
The console should be created with maxLogLevel: "Off" and log() should call console.debug unconditionally, letting the log module decide what is shown.
| Assignee | ||
Comment 1•1 month ago
|
||
A console created with the EME prefix already logs through the EME log module,
so searching MOZ_LOG for "EME" was redundant, and ignored the logging.EME pref.
Updated•1 month ago
|
Attachment #9656851 -
Attachment description: WIP: Bug 2078666 - Log the WMF CDM origins list through the console's EME log module. r?#media-playback-reviewers → WIP: Bug 2080173 - Log the WMF CDM origins list through the console's EME log module. r?#media-playback-reviewers
Updated•1 month ago
|
Attachment #9656851 -
Attachment description: WIP: Bug 2080173 - Log the WMF CDM origins list through the console's EME log module. r?#media-playback-reviewers → Bug 2080173 - Don't parse MOZ_LOG in the WMF CDM origins list service. r?#media-playback-reviewers
Pushed by dcarver@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/d40bd40c6d71
https://hg.mozilla.org/integration/autoland/rev/5cc7abd8f59a
Don't parse MOZ_LOG in the WMF CDM origins list service. r=media-playback-reviewers,padenot
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox160:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
Updated•24 days ago
|
QA Whiteboard: [qa-triage-done-c161/b160]
You need to log in
before you can comment on or make changes to this bug.
Description
•