2080180 - Make MediaCodec decoders work in the GPU process as well as RDD

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task)

Description

[Andrew Osmond [:aosmond] (he/him)]

This blocks AImageReader from just working because we are in the wrong process. We need the RDD in case we fall back to parent process compositing on Android, but we can default to using the GPU process for decoding for AImageReader purposes.

Comment 1

[Sotaro Ikeda [:sotaro]]

D279451 of Bug 1649110 pref change enables AImageReader and native MediaCodec in GPU process.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 2080180 - Part 1. Prefer decoding and encoding in the GPU process on Android, including with a CDM.

This allows MediaCodec video decoding to use AImageReader. The CDM must be in
the same process as the decoders using it, so the CDM is created in the GPU
process when decoding there is enabled, and only then may audio be decoded
there. If the GPU process is disabled, we fall back to the RDD process. We also
no longer disable decoding in the GPU process separately on Android after
crashes, so a decoder which repeatedly crashes the GPU process will cause it to
be relaunched until it is disabled entirely after too many restarts. The GPU
process now also probes for MediaCodec encoders, so that encoding is preferred
there in the same way, and the media manager endpoint for the GPU process is
created if either decoding or encoding there is enabled.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 2080180 - Part 2. Only fallback to platform decoding and encoding in the RDD process on Android if the GPU process is disabled.

The RDD process no longer creates MediaCodec decoders or encoders while the GPU
process is enabled and decoding or encoding in it is preferred, and the content
process no longer reports hardware decoding support for the RDD process then.
Pure software decoding and encoding with ffvpx may still be performed outside
of the GPU process since it is not permitted there.

Note that if creating a decoder in the GPU process fails for a reason other
than a crash, we no longer retry with MediaCodec in the RDD process, so codecs
without a software decoder, such as H264 and HEVC, will fail to decode.

The test checks that video decoding prefers the GPU process, and that only
hardware decoding is performed in the GPU process, and only software decoding
is performed in the RDD process unless the GPU process is unavailable.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 2080180 - Part 3. Use the GPU process for encoding/decoding with Android isolated process tests by default.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e16a53883576
https://hg.mozilla.org/integration/autoland/rev/8cd5e3a984a9
Part 1. Prefer decoding and encoding in the GPU process on Android, including with a CDM. r=media-playback-reviewers,alwu
https://github.com/mozilla-firefox/firefox/commit/7b75939485a1
https://hg.mozilla.org/integration/autoland/rev/f7acecbf2a9f
Part 2. Only fallback to platform decoding and encoding in the RDD process on Android if the GPU process is disabled. r=media-playback-reviewers,alwu
https://github.com/mozilla-firefox/firefox/commit/32d91c7937fb
https://hg.mozilla.org/integration/autoland/rev/15f537110a84
Part 3. Use the GPU process for encoding/decoding with Android isolated process tests by default. r=media-playback-reviewers,alwu

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/8cd5e3a984a9
https://hg.mozilla.org/mozilla-central/rev/f7acecbf2a9f
https://hg.mozilla.org/mozilla-central/rev/15f537110a84