Closed Bug 2080205 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 63428 - Revert "Keep wavy text decorations continuous across fragments"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox160 fixed)

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 63428 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/63428
Details from upstream follow.

luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> wrote:

Revert "Keep wavy text decorations continuous across fragments"

This reverts commit 198d0b60e4b380d9af19291d6f36813a808c675b.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5682156132106240

Sample build with failed test: https://ci.chromium.org/b/8668501104388031185
Affected test(s):
://:blink_web_tests!webtest::fast/ruby#text-decoration.html

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5682156132106240&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F8456548&type=BUG

Original change's description:

Keep wavy text decorations continuous across fragments

Anchor the wavy pattern at the start of the decorating box instead of
each fragment's own origin, so the wave phase no longer restarts at
inline element boundaries like a nested \<em>. Behind the default-on
WavyDecorationContinuousPhase runtime feature as a kill switch.

Bug: 41287729
Change-Id: Ia6ec134cdab6bbb3d2f7f64b631bc499bd9f4a56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8456548
Commit-Queue: Helmut Januschka \<helmut@januschka.com>
Reviewed-by: Fredrik Söderquist \<fs@opera.com>
Cr-Commit-Position: refs/heads/main@{#1714354}

Bug: 41287729
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I4b5bb2b004bc749a841868b43fe1c4bc945efed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8536782
Reviewed-by: Andy Phan \<andyphan@chromium.org>
Commit-Queue: Andy Phan \<andyphan@chromium.org>
Owners-Override: Andy Phan \<andyphan@chromium.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com \<rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1714737}

Whiteboard: [wptsync downstream] → [wptsync downstream error]

PR 63428 applied with additional changes from upstream: 29099a8c15ed232af88aa20ca411dafe9f062e7d

Whiteboard: [wptsync downstream error] → [wptsync downstream]

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/4de9f8f080a6 https://hg.mozilla.org/integration/autoland/rev/da3d874d399d [wpt PR 63428] - Revert "Keep wavy text decorations continuous across fragments", a=testonly

Test result changes from PR not available.

Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
You need to log in before you can comment on or make changes to this bug.