Closed Bug 2080211 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 63423 - [html-in-canvas] Switch to canvas getter for element width/height

Categories

(Core :: Graphics: Canvas2D, task, P4)

task

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 63423 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/63423
Details from upstream follow.

Philip Rogers <pdr@chromium.org> wrote:

[html-in-canvas] Switch to canvas getter for element width/height

ElementImage violated [1] due to being a mix of static and live. This
patch makes ElementImage static and moves the width/height data to a
getter on canvas, as the data depends on canvas width/height
attributes.

[1] https://w3ctag.github.io/design-principles/#live-vs-static

Change-Id: I75edadd24f985b64b974392a5145fb00e5454fdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8531547
Reviewed-by: Stefan Zager \<szager@chromium.org>
Auto-Submit: Philip Rogers \<pdr@chromium.org>
Commit-Queue: Stefan Zager \<szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1714586}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Graphics: Canvas2D
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Attached file Notable wpt changes —

CI Results

Ran 4 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 152 tests and 6 subtests

Status Summary

Firefox

OK : 6[GitHub] 137[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 12
FAIL : 15[GitHub] 252[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
TIMEOUT: 1
ERROR : 2[GitHub] 9[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
NOTRUN : 1[GitHub] 22[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 7
FAIL : 15
TIMEOUT: 1
ERROR : 1

Safari

OK : 6
FAIL : 15
ERROR : 2
NOTRUN : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

(See attachment for full changes)

Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: