Closed
Bug 2080264
Opened 1 month ago
Closed 1 month ago
Hide the labels on top row of navigation icons in browser screen menu
Categories
(Focus :: General, enhancement)
Tracking
(firefox159 verified, firefox160 verified, firefox161 verified)
VERIFIED
FIXED
160 Branch
People
(Reporter: mcarare, Assigned: mcarare)
References
Details
Attachments
(2 external files)
We should not add the content description as a label for the icons, keeping the minimalist style we previously had.
| Assignee | ||
Comment 1•1 month ago
|
||
- Update
MenuGridItemto center icons vertically and hide the title text and spacer when the title is empty. - Add a
showTextflag to menu item construction inBrowserMenuandCustomTabMenu. - Hide text titles for toolbar navigation items (Back, Forward, Share, Stop, Reload) while preserving accessibility content descriptions.
Pushed by jonalmeida942@gmail.com:
https://github.com/mozilla-firefox/firefox/commit/9b573894b92c
https://hg.mozilla.org/integration/autoland/rev/f103266482e8
Hide text labels for browser menu navigation items in Focus. r=android-reviewers,jonalmeida
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox160:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
Comment 4•26 days ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined/Reason for urgency: text showing below navigation icons.
- Code covered by automated testing?: yes
- Fix verified in Nightly?: yes
- Needs manual QE testing?: yes
- Steps to reproduce for manual QE testing: open menu from browser screen, check if navigation icons have text below them
- Risk associated with taking this patch: low
- Explanation of risk level: verified in nightly, just hides labels for navugation buttons in menu.
- String changes made/needed?: no
- Is Android affected?: yes
Attachment #9666567 -
Flags: approval-mozilla-beta?
Flags: qe-verify+
| Assignee | ||
Comment 5•26 days ago
|
||
- Update
MenuGridItemto center icons vertically and hide the title text and spacer when the title is empty. - Add a
showTextflag to menu item construction inBrowserMenuandCustomTabMenu. - Hide text titles for toolbar navigation items (Back, Forward, Share, Stop, Reload) while preserving accessibility content descriptions.
Original Revision: https://phabricator.services.mozilla.com/D332475
Updated•26 days ago
|
Attachment #9666567 -
Flags: approval-mozilla-beta? → approval-mozilla-release?
Updated•26 days ago
|
Attachment #9666567 -
Flags: approval-mozilla-release? → approval-mozilla-release+
Updated•26 days ago
|
status-firefox159:
--- → fixed
Updated•25 days ago
|
QA Whiteboard: [qa-triage-done-c161/b160]
Comment 7•25 days ago
|
||
Verified as fixed on the Focus 159.0, Focus Beta 160.0b1, and Focus Nightly 161.0a1, using a Xiaomi Mi8 Lite (Android 10).
You need to log in
before you can comment on or make changes to this bug.
Description
•