Closed Bug 2080321 Opened 1 month ago Closed 1 month ago

[miscellaneous] Shorten the isolated process variant's Treeherder symbol to iso

Categories

(Firefox Build System :: Task Configuration, task)

task
Points:
3

Tracking

(firefox160 fixed)

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: owlish, Assigned: owlish)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid])

Attachments

(1 external file)

The geckoview-isolated-process variant currently appears on Treeherder as -isolated, which crowds the symbol column for the suites that use it. Shortening it needs treeherder-suffix: "iso" on the variant, which leaves suffix - and therefore task names - unchanged.

That alone breaks the decision task:

Exception: Treeherder group W-iso-cf (from taskcluster/kinds/web-platform-tests/kind.yml) has no name; add it to taskcluster/config.yml

apply_variant in taskcluster/gecko_taskgraph/transforms/task.py builds the symbol from treeherder-suffix falling back to suffix, but _variant_symbols strips variants out of group symbols using suffix only. A group symbol built from treeherder-suffix can therefore never be reduced to a known base symbol, and build_task raises. This affects any variant that sets treeherder-suffix and also appears in a group position. The two existing users, standalone and the openh264 variant, only appear in symbol position, so it has not come up before.

Aligning _variant_symbols with apply_variant fixes it.

Resulting symbols, verified by generating the autoland task graph:

gv-junit(iso1) .. gv-junit(iso4)
M-iso(1)        mochitest
W-iso(webrtc)   web-platform-tests
X-iso(X)        xpcshell

Task names are unchanged, so try_presets.yml queries and anything else matching on task name are unaffected.

Severity: -- → N/A
Assignee: nobody → bugzeeeeee
Whiteboard: [fxdroid]
Points: --- → 3
Blocks: 2068254

Doesn't really block Bug 2068254, just doing this while I'm at that one

Summary: Shorten the isolated process variant's Treeherder symbol to iso → [random] Shorten the isolated process variant's Treeherder symbol to iso
Summary: [random] Shorten the isolated process variant's Treeherder symbol to iso → [miscellaneous] Shorten the isolated process variant's Treeherder symbol to iso
Points: 3 → 2
Points: 2 → 3
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: