[miscellaneous] Shorten the isolated process variant's Treeherder symbol to iso
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(firefox160 fixed)
| Tracking | Status | |
|---|---|---|
| firefox160 | --- | fixed |
People
(Reporter: owlish, Assigned: owlish)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid])
Attachments
(1 external file)
The geckoview-isolated-process variant currently appears on Treeherder as -isolated, which crowds the symbol column for the suites that use it. Shortening it needs treeherder-suffix: "iso" on the variant, which leaves suffix - and therefore task names - unchanged.
That alone breaks the decision task:
Exception: Treeherder group W-iso-cf (from taskcluster/kinds/web-platform-tests/kind.yml) has no name; add it to taskcluster/config.yml
apply_variant in taskcluster/gecko_taskgraph/transforms/task.py builds the symbol from treeherder-suffix falling back to suffix, but _variant_symbols strips variants out of group symbols using suffix only. A group symbol built from treeherder-suffix can therefore never be reduced to a known base symbol, and build_task raises. This affects any variant that sets treeherder-suffix and also appears in a group position. The two existing users, standalone and the openh264 variant, only appear in symbol position, so it has not come up before.
Aligning _variant_symbols with apply_variant fixes it.
Resulting symbols, verified by generating the autoland task graph:
gv-junit(iso1) .. gv-junit(iso4)
M-iso(1) mochitest
W-iso(webrtc) web-platform-tests
X-iso(X) xpcshell
Task names are unchanged, so try_presets.yml queries and anything else matching on task name are unaffected.
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Updated•1 month ago
|
Updated•1 month ago
|
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Comment 1•1 month ago
|
||
Doesn't really block Bug 2068254, just doing this while I'm at that one
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Comment 2•1 month ago
|
||
| Assignee | ||
Comment 3•1 month ago
|
||
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Updated•1 month ago
|
Description
•