Closed Bug 2080339 Opened 1 month ago Closed 24 days ago

Clicking the three dots on the top right on about:profiling closes it immidiately when releasing the mouse button

Categories

(Toolkit :: UI Widgets, defect, P2)

defect

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr153 --- unaffected
firefox158 --- unaffected
firefox159 --- wontfix
firefox160 --- wontfix
firefox161 --- fixed

People

(Reporter: manuel, Assigned: akulyk)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [recomp])

Attachments

(1 file, 1 external file)

Regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7c64a9ad6b0c91cc62a220d5652d8cb4d392128e&tochange=a72269cf0415a8d963d21e68ea3f5539464d80ca
I confirmed by reverting 873d7726c83c locally that bug 2071887 is the regressor.
I'm not aware of any other menus being broken due to this change, but there might be others affected too.

STR:

  1. Go to about:profiling
  2. click on three dot menu

Expected result: Menu opens
Got result: menu closes immidiately

Set release status flags based on info from the regressing bug 2071887

:mlucks, since you are the author of the regressor, bug 2071887, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

With claude I found one other much more user facing affected button: Migration wizard profile/browser selector in about:welcome.

Attached video about-welcome.mp4 —
Severity: -- → S3
Priority: -- → P2
Whiteboard: [recomp]
See Also: → 2079262
Flags: needinfo?(mlucks)
See Also: → 2076103

There seems to be two issues with the panel that we are playing whack-a-mole over:

  1. Can sometimes open multiple panels at the same time and any currently open panels will move all the way to the right (this was resolved with part 1 of 2058028)
  2. Moving the cursor while mid-click can cause the panel to position all the way to the right (this was "resolved" on the regressing bug 2071887)

I have added 2076103 to the "see also" since this would be the 3rd instance of the panels moving unexpectedly.

Please LMK if this bug should go to the AI Frontend team, or if this should stay with Acorn/recomp? Same questions regarding ownership for 2076103. Smart Window is seeing the issues, but since this is a globally used component, I can understand the recomp team might want to take a closer look.

NI for @akulyk since I see they made the most recent updates for priority and severity, but please lmk if this is a question for someone else.

Thanks!

Flags: needinfo?(akulyk)

From my investigation, Bug 2071887 did not cause this issue, it just exposed callers that were already broken. So I believe it should be an Acorn/recomp bug

Flags: needinfo?(akulyk)
Assignee: nobody → akulyk

These menus open on mousedown from a button that isn't the panel-list's popover
invoker, so the UA treats the release as outside the popover and light-dismisses
it. Since bug 2071887 panel-list follows that dismissal, closing the menu as
soon as the mouse button is released. Use moz-button's menuId in about:profiling
and set popoverTargetElement on the migration wizard's selector, and document
the invoker requirement in the panel-list README.

(In reply to Manuel Bucher [:manuel] from comment #2)

With claude I found one other much more user facing affected button: Migration wizard profile/browser selector in about:welcome.

The fix for the migration wizard is a part of Bug 2078922

Attachment #9659149 - Attachment description: Bug 2080339 - Register panel-list anchors as popover invokers in about:profiling and the migration wizard. r?#reusable-components-reviewers → Bug 2080339 - Register panel-list anchors as popover invokers in about:profiling. r?#reusable-components-reviewers
Pushed by akulyk@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/7ab28335841a https://hg.mozilla.org/integration/autoland/rev/bbe7e1287f07 Register panel-list anchors as popover invokers in about:profiling. r=profiler-reviewers,mstriemer,canova
Status: NEW → RESOLVED
Closed: 24 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch

The patch landed in nightly and beta is affected.

:akulyk, please make an uplift decision for beta:

  • For beta, nominate the patch for beta uplift approval if the fix should be included in this release, or set status-firefox160 to wontfix if the fix can wait for the next release.

See Requesting an Uplift for documentation on how to request an uplift.

For more information, please visit BugBot documentation.

Flags: needinfo?(akulyk)
Flags: needinfo?(akulyk)
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: